Smoke test script fails due to missing function in tracker.sh

[rklonner]

What's broken?

The smoke test script fails due to a missing function named track_smoketest_completed() in tracker.sh.

However, the function is available in tracker-legacy.sh

A workaround is to add the function from tracker-legacy.sh to tracker.sh, afterwards the smoke test runs successfully.

If the workaround is the solution I would like to contribute or get guidance for a cleaner solution.

Steps to reproduce

1. Open codespace for adventure 01 - Beginner
2. Solve the task by overwriting adventures/01-echoes-lost-in-orbit/beginner/manifests/appset.yaml with

apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: echo-server
  namespace: argocd
spec:
  generators:
    - git:
        repoURL: https://github.com/off-on-dev/open-source-challenges.git
        revision: HEAD
        directories:
          - path: adventures/01-echoes-lost-in-orbit/beginner/manifests/overlays/*
  template:
    metadata:
      name: echo-server-{{path.basename}}
      labels:
        app.kubernetes.io/managed-by: argocd
    spec:
      project: default
      source:
        repoURL: https://github.com/off-on-dev/open-source-challenges.git
        targetRevision: HEAD
        path: adventures/01-echoes-lost-in-orbit/beginner/manifests/overlays/{{path.basename}}
      destination:
        server: https://kubernetes.default.svc
        namespace: echo-{{path.basename}}
      syncPolicy:
        automated:
          selfHeal: true
          prune: true
        syncOptions:
          - CreateNamespace=true

3. Apply the solution kubectl apply -n argocd -f adventures/01-echoes-lost-in-orbit/beginner/manifests/appset.yaml
4. Execute smoke test: adventures/01-echoes-lost-in-orbit/beginner/smoke-test.sh

Full output:

╔════════════════════════════════════════════════════════════╗
║ ║
║ Challenge 01: Echoes Lost in Orbit ║
║ Level 1: Broken Echoes ║
║ Smoke Test Verification ║
║ ║
╚════════════════════════════════════════════════════════════╝

Checking prerequisites...
✓ All prerequisites met

Running smoke tests...

🔬 Checking Staging Environment
✓ Namespace 'echo-staging' exists
✓ Service echo-server-staging in 'echo-staging' exists
⏳ HTTP GET http://localhost:8081/healthz...
✓ App is reachable at http://localhost:8081/healthz and returned expected content

✅ Staging is healthy!

🔬 Checking Production Environment
✓ Namespace 'echo-prod' exists
✓ Service echo-server-prod in 'echo-prod' exists
⏳ HTTP GET http://localhost:8082/healthz...
✓ App is reachable at http://localhost:8082/healthz and returned expected content

✅ Production is healthy!

╔════════════════════════════════════════════════════════════╗
║ ║
║ Test Results Summary ║
║ ║
╚════════════════════════════════════════════════════════════╝

/workspaces/open-source-challenges/lib/scripts/output.sh: line 100: track_smoketest_completed: command not found

Error:
/workspaces/open-source-challenges/lib/scripts/output.sh: line 100: track_smoketest_completed: command not found

Expected behavior

The script should pass and print a success message

Where?

• https://github.com/off-on-dev/open-source-challenges/blob/main/adventures/01-echoes-lost-in-orbit/beginner/smoke-test.sh
• https://github.com/off-on-dev/open-source-challenges/blob/main/lib/scripts/tracker.sh
• https://github.com/off-on-dev/open-source-challenges/blob/main/lib/scripts/tracker-legacy.sh

[KatharinaSick]

Thanks a lot for reporting & the detailed bug report @rklonner. I'm sorry, that you didn't have a good experience playing right away! That bug must have slipped through when we migrated to the new community (offon.dev).

The fix should be to source the legacy tracker in the smoke test script like here.
I couldn't test and therefore verify that yet though.

As you mentioned contributing a fix: contributions are very welcome and I'd be happy to assign the ticket to you. I also get it, if you want to work on more interesting stuff and am good to implement and test the fix myself too. Just let me know what you prefer :)