Consolidate numpy conversion functions

[dfulu]

Currently we have a whole suite of numpy conversion functions in the numpy_sample module. In the samplers we convert each modality into a dictionary separately and then merge the dictionaries.

I think it could be cleaner to create a single function which replaces all the numpy conversion functions in the numpy_sample module. As part of this I would also suggest that we should remove all of the {X}SampleKey classes scattered throughout the numpy_sample module. Instead all of the keys of the returned dictionary would be obvious from the new single numpy conversion function.

The new conversion function could accept a dictionary of xarray objects identical to the dictionary we pass around inside the PVNet Dataset classes to slice time and space components. We'd need to decide a little more on how to add t0, the time encodings and the solar coords to the sample, but I feel like this should be reasonably straight forward

[yuvraajnarula]

@dfulu if this issue is not resolved, I would like to contribute.

[dfulu]

Hi @yuvraajnarula thanks for the offer. This issue is blocked now until after #375 is finished and merged

[yuvraajnarula]

@dfulu
saw that PR #375 got merged
Can I work on this now? Will there be any changes when it comes to the scope of this issue after the PR?

[dfulu]

@yuvraajnarula this issue is open now yes. I can assign it to you if you want to take it on. There shouldn't be any scope changes

[yuvraajnarula]

Yes sure, would love work on this

[vedantvakharia]

Hi! I noticed this issue has been open for a while.
If the current assignee doesn’t mind, I would like to take this issue and work on it.
Please let me know if I can proceed.

[yuvraajnarula]

Hi there! I’m actually already in the middle of resolving this issue. I’ve made some progress and expect to raise a PR shortly after a few final tweaks. Would you mind looking into a different open issue instead? Thanks for your understanding!