From 66a64ba335bfcfcf5dd6df7f0b63624cc00e6c73 Mon Sep 17 00:00:00 2001
From: Petr Muller <muller@redhat.com>
Date: Thu, 30 Apr 2026 18:28:09 +0200
Subject: [PATCH] Allow info and list tests commands to work without KUBECONFIG

Split initFrameworkForTests() into initFrameworkDefaults() (runs at
startup without KUBECONFIG) and initFrameworkCluster() (deferred to
AddBeforeAll, requires KUBECONFIG). This enables workflows that need
to discover or list tests without a live cluster connection, such as
the openshift-tests "list all-tests" command.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 openshift-tests/ccm-aws-tests/main.go | 47 ++++++++++++++-------------
 1 file changed, 25 insertions(+), 22 deletions(-)

diff --git a/openshift-tests/ccm-aws-tests/main.go b/openshift-tests/ccm-aws-tests/main.go
index eb9e37892..3cd7fd981 100644
--- a/openshift-tests/ccm-aws-tests/main.go
+++ b/openshift-tests/ccm-aws-tests/main.go
@@ -39,10 +39,10 @@ func main() {
 		Qualifiers: []string{`!labels.exists(l, l == "Serial") && labels.exists(l, l == "Conformance")`},
 	})
 
-	// Initialize framework for the tests.
-	if err := initFrameworkForTests(); err != nil {
-		panic(fmt.Errorf("failed to initialize test framework: %w", err))
-	}
+	// Initialize framework with cluster-independent settings. Cluster-dependent
+	// initialization (kubeconfig, host) is deferred to AddBeforeAll so that
+	// "info" and "list tests" commands work without cluster access.
+	initFrameworkDefaults()
 
 	// Build the extension test specs
 	specs, err := g.BuildExtensionTestSpecsFromOpenShiftGinkgoSuite()
@@ -82,6 +82,9 @@ func main() {
 
 	}).Include(extensiontests.PlatformEquals("aws"))
 	specs.AddBeforeAll(func() {
+		if err := initFrameworkCluster(); err != nil {
+			panic(fmt.Errorf("failed to initialize cluster config: %w", err))
+		}
 		if err := initFrameworkForTest(); err != nil {
 			panic(fmt.Errorf("failed to initialize test framework: %w", err))
 		}
@@ -124,17 +127,12 @@ func getRegionFromEnv() string {
 	return ""
 }
 
-// initFrameworkForTests initializes the framework for the tests globally.
-func initFrameworkForTests() error {
-	if len(os.Getenv("KUBECONFIG")) == 0 {
-		return fmt.Errorf("KUBECONFIG is empty. Set the KUBECONFIG environment variable")
-	}
-
-	// Initialize framework - required for test discovery
-	// TODO:
-	// 1. Fix the provider getting from env (when ote supports aws)
-	// 2. Build the config from the env, and set the testContext.CloudConfig (if required by the test)
-	// 3. Move this init to a dedicated function
+// initFrameworkDefaults sets cluster-independent framework defaults needed
+// for test discovery. This runs at startup and does not require KUBECONFIG.
+// TODO:
+// 1. Fix the provider getting from env (when ote supports aws)
+// 2. Build the config from the env, and set the testContext.CloudConfig (if required by the test)
+func initFrameworkDefaults() {
 	testContext.Provider = "local" // TODO: OTE supports local or skeleton
 
 	// Set up AWS cloud configuration when environment variables are set.
@@ -157,7 +155,18 @@ func initFrameworkForTests() error {
 	testContext.NodeOSDistro = "custom"
 	testContext.MasterOSDistro = "custom"
 
-	// Load kube client config and set the host variable for kubectl
+	// Must be called during startup (before the Ginkgo tree is built) because it
+	// internally calls ginkgo.PreviewSpecs which clones the suite.
+	framework.AfterReadingAllFlags(testContext)
+}
+
+// initFrameworkCluster loads kubeconfig and sets the host for kubectl.
+// This is called in AddBeforeAll so that "info" and "list tests" work without cluster access.
+func initFrameworkCluster() error {
+	if len(os.Getenv("KUBECONFIG")) == 0 {
+		return fmt.Errorf("KUBECONFIG is empty. Set the KUBECONFIG environment variable")
+	}
+
 	testContext.KubeConfig = os.Getenv("KUBECONFIG")
 	clientConfig := clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
 		&clientcmd.ClientConfigLoadingRules{
@@ -171,12 +180,6 @@ func initFrameworkForTests() error {
 	}
 	testContext.Host = cfg.Host
 
-	// After reading all flags, this will configure the test context, and need to be
-	// called once by framework to avoid re-configuring the test context, and leding
-	// to issues in Ginkgo phases (PhaseBuildTopLevel, PhaseBuildTree, PhaseRun),
-	// such as:'cannot clone suite after tree has been built'
-	framework.AfterReadingAllFlags(testContext)
-
 	return nil
 }