From 2ca3edc62aeeb9ad363fba57499267e4bd038657 Mon Sep 17 00:00:00 2001 From: Pablo Acevedo Montserrat Date: Tue, 19 May 2026 10:39:13 +0200 Subject: [PATCH] USHIFT-6986: Add retry and error handling to cfssl downloads in CNCF conformance The cfssl binary downloads in configure-pri.sh intermittently fail due to transient network issues, causing silent checksum mismatches because curl saves error responses as the output file. Add --fail to reject HTTP errors, --retry with --retry-all-errors for resilience, and -S to surface errors in logs for debugging. --- scripts/multinode/configure-pri.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/multinode/configure-pri.sh b/scripts/multinode/configure-pri.sh index fc78c274bc..8fe2942799 100755 --- a/scripts/multinode/configure-pri.sh +++ b/scripts/multinode/configure-pri.sh @@ -112,8 +112,10 @@ function generate_service_certs() { exit 1 esac - curl -s -L -o "${cfssl}" "https://github.com/cloudflare/cfssl/releases/download/v1.6.4/cfssl_1.6.4_linux_${cfssl_arch}" - curl -s -L -o "${cfssl_json}" "https://github.com/cloudflare/cfssl/releases/download/v1.6.4/cfssljson_1.6.4_linux_${cfssl_arch}" + curl -sS -L --fail --retry 5 --retry-delay 5 --retry-all-errors -o "${cfssl}" \ + "https://github.com/cloudflare/cfssl/releases/download/v1.6.4/cfssl_1.6.4_linux_${cfssl_arch}" + curl -sS -L --fail --retry 5 --retry-delay 5 --retry-all-errors -o "${cfssl_json}" \ + "https://github.com/cloudflare/cfssl/releases/download/v1.6.4/cfssljson_1.6.4_linux_${cfssl_arch}" cat < "${cfssl_sha}" ${cfssl_map[cfssl]} ${cfssl} ${cfssl_map[cfssl_json]} ${cfssl_json}