Replace upstream Secrets Store CSI driver manifests with OCP operator#80275
Replace upstream Secrets Store CSI driver manifests with OCP operator#80275psalajova wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughReplace manual Secrets Store CSI Driver manifests with an OLM-based installation: add OperatorGroup and Subscription for Red Hat's secrets-store-csi-driver-operator and register a ClusterCSIDriver; README updated to document operator-managed components in the openshift-cluster-csi-drivers namespace. ChangesOperator-Managed CSI Driver Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold we need to first upgrade all build clusters to 4.21 |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@psalajova: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The upstream CSI driver images don't support s390x/ppc64le architectures, causing CrashLoopBackOff on multi-arch nodes. This replaces the manually-managed upstream manifests (DaemonSet, CRDs, RBAC, CSIDriver) with the Red Hat Secrets Store CSI Driver Operator installed via OLM, whose images support all architectures. The GCP provider DaemonSet and SecretProviderClass are kept as-is since the operator doesn't manage those. Tested on build11 -- operator deploys driver pods successfully on all nodes including s390x.
Summary by CodeRabbit
This PR updates build-cluster CSI secrets management to use the Red Hat Secrets Store CSI Driver Operator (installed via OLM) instead of the upstream manually-managed Secrets Store CSI driver manifests.
Infrastructure affected: build clusters' CSI secrets configuration under clusters/build-clusters/build-shared/csi-secrets-gcp/
What changed in practical terms:
Why this was done:
Notes: