Skip to content

CNTRLPLANE-3558: Migrate test OCP-48672 Multi-zone AWS infra + NodePo…#80289

Open
mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:multizone_setup
Open

CNTRLPLANE-3558: Migrate test OCP-48672 Multi-zone AWS infra + NodePo…#80289
mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:multizone_setup

Conversation

@mgencur

@mgencur mgencur commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

…ols across zones

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3558

Extend the Cilium tests to include multi-zone setup. Choosing Cilium arbitrarily. We just want to add the multi-zone to an existing config to prevent bloating the CI test matrix.

Summary by CodeRabbit

This PR extends the HyperShift AWS Cilium conformance workflow to support multi-zone deployment by explicitly configuring AWS region and availability zone settings. The changes update the workflow environment in ci-operator/step-registry/hypershift/aws/conformance-cilium/hypershift-aws-conformance-cilium-workflow.yaml to:

  • Pin the AWS region to us-east-1 (via new HYPERSHIFT_AWS_REGION environment variable)
  • Specify three availability zones in that region (us-east-1a,us-east-1b,us-east-1c) for the HYPERSHIFT_HC_ZONES variable

This migration enables the existing Cilium test suite to validate networking across multiple AWS availability zones, similar to test OCP-48672 (Multi-zone AWS infra + NodePools across zones), without expanding the test matrix by creating entirely new test configurations. The approach follows the OpenShift CI pattern of adding multi-zone capability through environment variable configuration rather than test duplication.

…ols across zones

Extend the Cilium tests to include multi-zone setup
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@mgencur: This pull request references CNTRLPLANE-3558 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

…ols across zones

Extend the Cilium tests to include multi-zone setup. Choosing Cilium arbitrarily. We just want to add the multi-zone to an existing config to prevent bloating the CI test matrix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6bcf5e50-b6d2-4864-a17e-3048ef21166a

📥 Commits

Reviewing files that changed from the base of the PR and between 6ae1354 and 7d98f0b.

📒 Files selected for processing (1)
  • ci-operator/step-registry/hypershift/aws/conformance-cilium/hypershift-aws-conformance-cilium-workflow.yaml

Walkthrough

This PR updates the HyperShift AWS cilium conformance workflow to explicitly pin execution to the us-east-1 region by setting HYPERSHIFT_AWS_REGION to us-east-1 and constraining the cluster zones to us-east-1a,us-east-1b,us-east-1c via the HYPERSHIFT_HC_ZONES variable.

Changes

Regional constraint configuration

Layer / File(s) Summary
HyperShift region and zone environment variables
ci-operator/step-registry/hypershift/aws/conformance-cilium/hypershift-aws-conformance-cilium-workflow.yaml
Workflow environment variables pinned to us-east-1 region and three specific availability zones within that region.

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error File contains three RedHat email addresses in documentation comments (agarcial@redhat.com, sjenning@redhat.com, cewong@redhat.com), which is PII that could be exposed in logs. Remove personal email addresses from documentation or replace with team mailing list/generic contact information to avoid exposing PII.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: migrating test OCP-48672 to include multi-zone AWS infrastructure setup in the HyperShift AWS Cilium conformance workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only a CI workflow YAML file with environment variables. No Ginkgo test code is modified or added, so the stable test names check does not apply.
Test Structure And Quality ✅ Passed PR contains only workflow YAML configuration, not Ginkgo test code. Check for test structure and quality is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The changes only create CI/CD workflow configuration files (YAML) that reference existing test chains, not new test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds no new Ginkgo e2e tests - only workflow environment variable changes. Check applies only to new tests.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI/CD workflow configuration (environment variables for test regions/zones), not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI workflow YAML configuration, not OTE binary source code. Check is not applicable to openshift/release repository.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only workflow YAML configuration files, not Ginkgo test code. No test patterns (It, Describe, Context, When) were added.
No-Weak-Crypto ✅ Passed PR modifies only a YAML workflow configuration file with environment variables; contains no code, cryptographic implementations, or weak crypto algorithms.
Container-Privileges ✅ Passed PR adds only AWS region/zone environment variables to workflow YAML. No privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings found.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bryan-cox and sjenning June 9, 2026 12:39
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mgencur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-conformance-cilium N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-conformance-cilium N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-conformance-cilium N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-conformance-cilium N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-conformance-cilium N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-conformance-cilium N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mgencur

mgencur commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-conformance-cilium

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-conformance-cilium 7d98f0b link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-conformance-cilium

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants