Skip to content

override: allow osac-project/wg-infra to /override#80291

Open
omer-vishlitzky wants to merge 1 commit into
openshift:mainfrom
omer-vishlitzky:osac-1322-restrict-override
Open

override: allow osac-project/wg-infra to /override#80291
omer-vishlitzky wants to merge 1 commit into
openshift:mainfrom
omer-vishlitzky:osac-1322-restrict-override

Conversation

@omer-vishlitzky

@omer-vishlitzky omer-vishlitzky commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add osac-project: [wg-infra] to override.allowed_github_teams so that wg-infra team members can use /override on OSAC repos.

This is part of OSAC-1322 — restricting /override to infrastructure leads only. The companion OWNERS PRs (using filters: "[^.]": to empty TopLevelApprovers()) are submitted to each OSAC repo separately.

This PR should merge first (or simultaneously with the OWNERS PRs). If the OWNERS changes land first, wg-infra temporarily loses override access until this config lands.

Summary by CodeRabbit

This PR updates the Prow override plugin configuration to grant the wg-infra team override permissions for OSAC (OpenShift Assisted Cluster) project repositories.

Changes Made

The override.allowed_github_teams list in core-services/prow/02_config/_plugins.yaml is extended to include:

  • osac-project: wg-infra

This enables members of the wg-infra team to use the /override Prow command on CI jobs for OSAC repositories (such as fulfillment-service, osac-aap, osac-installer, osac-operator, osac-test-infra, and others).

Context

This change is part of OSAC-1322, which restricts override capability to infrastructure leads. Companion OWNERS file changes are being applied to each OSAC repository to limit top-level approvers. This Prow config change should merge first (or simultaneously) to ensure the wg-infra team maintains override access during the OWNERS file updates.

Add osac-project: [wg-infra] to the override plugin's
allowed_github_teams so that wg-infra members can use
/override on OSAC repos.

Part of OSAC-1322.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 191ded00-b0c6-42e4-a245-237c721c2006

📥 Commits

Reviewing files that changed from the base of the PR and between de3583a and 493c679.

📒 Files selected for processing (1)
  • core-services/prow/02_config/_plugins.yaml

Walkthrough

This PR extends the Prow plugin configuration to authorize the wg-infra team for override actions in the osac-project repository by adding a new allowlist entry to the override.allowed_github_teams section.

Changes

Prow plugin configuration update

Layer / File(s) Summary
Add osac-project to plugin override allowlist
core-services/prow/02_config/_plugins.yaml
Adds osac-project with the wg-infra team to override.allowed_github_teams, granting override permissions for that repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding osac-project/wg-infra to the override plugin's allowed teams.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only _plugins.yaml configuration and adds standard Go tests without Ginkgo. No Ginkgo test files with test titles are modified; check is not applicable.
Test Structure And Quality ✅ Passed This PR modifies only core-services/prow/02_config/_plugins.yaml, a Prow configuration file. It does not include any Ginkgo test code, so the test structure and quality check is not applicable.
Microshift Test Compatibility ✅ Passed This PR modifies only Prow configuration files (_plugins.yaml), not Ginkgo e2e tests. The check is not applicable since no test code additions are present.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only a YAML configuration file (_plugins.yaml) with no Ginkgo e2e tests or test code. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies a Prow plugin configuration file (_plugins.yaml), not deployment manifests, operator code, or controllers. Check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML configuration file (_plugins.yaml); OTE Binary Stdout Contract check applies only to Go/binary code, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only a Prow plugin configuration file (_plugins.yaml) and contains no Ginkgo e2e tests. The check applies only to new e2e tests and is not applicable here.
No-Weak-Crypto ✅ Passed PR modifies only a YAML config file adding team authorization. No weak cryptography (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto) detected.
Container-Privileges ✅ Passed PR modifies only Prow plugin config, not K8s/container manifests. No privilege escalation keywords found in file.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data found in changes. The PR only adds team names (osac-project/wg-infra) to an allowlist in a config file. No passwords, tokens, API keys, PII, session IDs, or credentials are exposed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from droslean and pruan-rht June 9, 2026 13:00
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@omer-vishlitzky: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@omer-vishlitzky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eliorerz eliorerz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@larsks: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eliorerz, larsks, omer-vishlitzky
Once this PR has been reviewed and has the lgtm label, please assign bear-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants