Skip to content

ROSAENG-8192 | task: Migrate cs-rosa-hcp-ad-integration-regional-main#80295

Open
davidleerh wants to merge 1 commit into
openshift:mainfrom
davidleerh:ROSAENG-8192-REGIONAL
Open

ROSAENG-8192 | task: Migrate cs-rosa-hcp-ad-integration-regional-main#80295
davidleerh wants to merge 1 commit into
openshift:mainfrom
davidleerh:ROSAENG-8192-REGIONAL

Conversation

@davidleerh

@davidleerh davidleerh commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR adds a new daily scheduled end-to-end test to the OpenShift CI infrastructure for the ROSA (Red Hat OpenShift Service on AWS) project.

What changed:
A new periodic test definition ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main has been added to the CI configuration file for the rosa-e2e repository's OCM (OpenShift Cluster Manager) FVT (Functional Verification Testing) pipeline. The test is configured to:

  • Run automatically every day at 8:00 AM UTC using cron scheduling
  • Execute in a containerized environment using nested-podman
  • Target the OCM integration environment
  • Reference the existing rosa-e2e-ocm-fvt test step
  • Allow up to 5 hours for test completion

Impact:
This migration establishes automated CI testing for the regional variant of ROSA HCP (Hosted Control Plane) with Active Directory integration. The new periodic test ensures continuous validation of the cs-rosa-hcp-ad-integration-regional-main component within the integration environment, helping catch regressions early in the development cycle.

@davidleerh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fb76c0cd-4258-42a1-ac86-085ecad0ed3c

📥 Commits

Reviewing files that changed from the base of the PR and between 95ce63c and f94c1cd.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml

Walkthrough

This PR adds a new periodic scheduled end-to-end test definition to the ROSA E2E OCM FVT integration configuration. The ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main job runs daily at 08:00 UTC in a nested-podman container, sets OCM FVT integration environment variables, references the rosa-e2e-ocm-fvt test, and allows 5 hours for execution.

Changes

ROSA E2E OCM FVT CI Configuration

Layer / File(s) Summary
New periodic OCM FVT integration test definition
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml
Added ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main with daily cron: 0 8 * * * schedule, nested-podman container, integration environment variables (OCM_FVT_JOB_NAME, OCM_FVT_OCM_ENV=integration), rosa-e2e-ocm-fvt test reference, and 5h0m0s timeout.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/release#80244: Both PRs modify the OpenShift Online CI YAML for OCM FVT scheduled rosa-e2e-ocm-fvt jobs—main PR adds a new periodic OCM FVT cron entry (integration), while the retrieved PR adjusts cron timing for multiple OCM FVT periodic staging jobs to stagger execution.
  • openshift/release#80229: The main PR adds a new periodic ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main job configured with a 5h timeout in the rosa-hcp-integration.yaml setup, which is directly aligned with the retrieved PR's changes increasing rosa-e2e ocm-fvt timeouts (including in the same rosa-hcp-integration config area).
  • openshift/release#80231: Both PRs add new scheduled ROSA E2E integration CI entries in the ci-operator/config/openshift-online/rosa-e2e/ YAMLs—using nested-podman and OCM_FVT_* integration-specific env vars to run OCM FVT tests on a daily cron—so the main PR's change is directly analogous to the retrieved PR's test-definition addition.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • ravitri
  • bmeng
  • tiwillia
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: migrating a specific CI test configuration (cs-rosa-hcp-ad-integration-regional-main) as indicated by the ROSAENG-8192 task reference and the YAML file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI/CD configuration (YAML) only, not Ginkgo test code. No Ginkgo test titles (It, Describe, Context, When) with dynamic content found; all job names are static and descriptive.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test structure is not applicable; PR modifies only CI/CD configuration YAML file, not test implementation code.
Microshift Test Compatibility ✅ Passed This PR adds a CI job configuration (YAML only), not new Ginkgo e2e tests. The custom check applies only to new Ginkgo tests (It(), Describe(), Context(), etc.), which are not present in this PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds YAML CI configuration for a containerized ocmtest job, not Ginkgo e2e tests. The custom check targets Ginkgo tests (It(), Describe(), etc.) which are not present in this PR.
Topology-Aware Scheduling Compatibility ✅ Passed Change is a CI test configuration file (ci-operator/config/) with no deployment manifests, operator code, or scheduling constraints. Not subject to topology-aware scheduling check.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration to add a scheduled test job; no source code or OTE binary process-level code changes present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds CI/operator YAML configuration to schedule an existing test ref. No new Ginkgo e2e tests (It(), Describe(), Context(), When()) are being added. Check is not applicable.
No-Weak-Crypto ✅ Passed PR modifies only a YAML CI configuration file with no cryptographic algorithms, custom crypto implementations, or secret comparisons. No weak crypto patterns detected.
Container-Privileges ✅ Passed No privileged container configurations found: YAML contains no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN capability, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed New test definition contains only non-sensitive configuration values with no hardcoded credentials, tokens, API keys, PII, or logging that would expose sensitive data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot requested review from bmeng and gdbranco June 9, 2026 14:38
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidleerh
Once this PR has been reviewed and has the lgtm label, please assign tiwillia for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@davidleerh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@davidleerh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@davidleerh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@davidleerh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main f94c1cd link unknown /pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-regional-main

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant