Add rebase-bot periodic configs for openshift/cri-o release branches#80300
Add rebase-bot periodic configs for openshift/cri-o release branches#80300bitoku wants to merge 2 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds CI-operator periodic configs that schedule ChangesCRI-O rebasebot periodic jobs
Sequence Diagram(s)sequenceDiagram
participant CronSchedule
participant CI_Operator
participant Rebasebot
participant GitHub
CronSchedule->>CI_Operator: trigger periodic job (Mon/Thu 12:00)
CI_Operator->>Rebasebot: start rebase job (source -> dest, --rebase)
Rebasebot->>GitHub: authenticate using mounted /secrets/rebasebot keys
Rebasebot->>CI_Operator: push results / report status
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bitoku The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
bitoku
force-pushed
the
cri-o-rebasebot-periodics
branch
from
d90d090 to
526ea73
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.12__periodics.yaml`:
- Around line 2-5: The rebasebot image references are pinned to tag: latest
causing non-deterministic runs; update both base_images.rebasebot.tag and the
step from_image.tag for the rebasebot step to a fixed release tag or,
preferably, an image digest (sha256:...) so the job is reproducible; ensure the
same exact tag/digest is used in both places (base_images.rebasebot.tag and the
rebasebot step's from_image.tag) and run a quick CI dry-run to verify the image
resolves.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: dbc7aeb7-60e5-45c8-8e24-bfd80e587884
⛔ Files ignored due to path filters (14)
ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.12-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.13-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.14-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.15-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.16-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.17-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.18-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.19-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.20-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-4.23-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cri-o/openshift-cri-o-release-5.1-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (14)
ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.12__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.13__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.14__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.15__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.16__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.17__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.18__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.19__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.20__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.21__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.22__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-4.23__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-5.0__periodics.yamlci-operator/config/openshift/cri-o/openshift-cri-o-release-5.1__periodics.yaml
| rebasebot: | ||
| name: rebasebot | ||
| namespace: ci | ||
| tag: latest |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify how widespread mutable `latest` usage is in the CRI-O periodics cohort.
fd -e yaml 'openshift-cri-o-release-.*__periodics\.yaml' ci-operator/config/openshift/cri-o \
| xargs rg -n '^\s*tag:\s*latest\s*$'Repository: openshift/release
Length of output: 2871
🏁 Script executed:
#!/bin/bash
set -euo pipefail
for f in \
ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.12__periodics.yaml \
ci-operator/config/openshift/cri-o/openshift-cri-o-release-5.0__periodics.yaml \
ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.23__periodics.yaml
do
echo "=== $f ==="
sed -n '1,80p' "$f" | nl -ba | sed -n '1,60p'
doneRepository: openshift/release
Length of output: 210
🏁 Script executed:
#!/bin/bash
set -euo pipefail
for f in \
ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.12__periodics.yaml \
ci-operator/config/openshift/cri-o/openshift-cri-o-release-5.0__periodics.yaml \
ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.23__periodics.yaml
do
echo "=== $f ==="
sed -n '1,90p' "$f" | nl -ba | sed -n '1,90p'
doneRepository: openshift/release
Length of output: 210
🏁 Script executed:
#!/bin/bash
set -euo pipefail
f="ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.12__periodics.yaml"
echo "=== $f (lines 1-60) ==="
awk 'NR>=1 && NR<=60 {printf "%4d\t%s\n", NR, $0}' "$f"
echo
echo "=== $f (lines 25-45) ==="
awk 'NR>=25 && NR<=45 {printf "%4d\t%s\n", NR, $0}' "$f"Repository: openshift/release
Length of output: 2330
Pin rebasebot image references (avoid tag: latest)
In openshift-cri-o-release-4.12__periodics.yaml, both base_images.rebasebot.tag (lines 2-5) and the step from_image.tag for rebasebot (lines 31-34) use latest, which makes periodic runs drift over time. Switch both to a fixed version tag or (preferred) an image digest.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/cri-o/openshift-cri-o-release-4.12__periodics.yaml`
around lines 2 - 5, The rebasebot image references are pinned to tag: latest
causing non-deterministic runs; update both base_images.rebasebot.tag and the
step from_image.tag for the rebasebot step to a fixed release tag or,
preferably, an image digest (sha256:...) so the job is reproducible; ensure the
same exact tag/digest is used in both places (base_images.rebasebot.tag and the
rebasebot step's from_image.tag) and run a quick CI dry-run to verify the image
resolves.
526ea73 to
61728da
Compare
|
/pj-rehearse periodic-ci-openshift-cri-o-release-4.22-periodics-rebasebot |
|
@bitoku: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-cri-o-release-4.22-periodics-rebasebot |
|
@bitoku: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
bitoku
force-pushed
the
cri-o-rebasebot-periodics
branch
from
61728da to
6fad771
Compare
|
/pj-rehearse periodic-ci-openshift-cri-o-release-4.22-periodics-rebasebot |
|
@bitoku: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
bitoku
force-pushed
the
cri-o-rebasebot-periodics
branch
from
6fad771 to
ec89286
Compare
Set up repo-owned rebasebot periodic jobs for all openshift/cri-o release branches (4.12 through 5.1), rebasing from upstream cri-o/cri-o release branches. Follows the pattern established in PR openshift#79774. Assisted-by: Claude Code <https://claude.com/claude-code>
Add node-rebasebot to trusted_apps in Prow trigger config so PRs from the app bypass needs-ok-to-test. Assisted-by: Claude Code <https://claude.com/claude-code>
bitoku
force-pushed
the
cri-o-rebasebot-periodics
branch
2 times, most recently
from
bc1054e to
15f0688
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@bitoku: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| resources: | ||
| '*': | ||
| limits: | ||
| memory: 4Gi |
There was a problem hiding this comment.
probably doesn't matter too much but this seems like a lot?
2 participants
Set up repo-owned rebasebot periodic jobs for all openshift/cri-o release branches (4.12 through 5.1), rebasing from upstream cri-o/cri-o release branches. Follows the pattern established in PR #79774.
Assisted-by: Claude Code https://claude.com/claude-code
Summary by CodeRabbit
This PR updates OpenShift CI configuration to add repository-owned rebasebot periodics for openshift/cri-o release branches 4.12 through 5.1 (14 new ci-operator periodics files). Each new periodic schedules an automated rebase of the corresponding openshift/cri-o release branch from the matching upstream cri-o release branch, running twice weekly (Mon & Thu at 12:00 UTC).
What changed (practical terms)
Practical impact