Skip to content

Fix tests-private-baseui DockerBuildFailed on release-4.19#80301

Open
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:fix-tests-private-4.19-image
Open

Fix tests-private-baseui DockerBuildFailed on release-4.19#80301
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:fix-tests-private-4.19-image

Conversation

@anuragthehatter

@anuragthehatter anuragthehatter commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace wget with curl for Google Chrome RPM download in tests-private-baseui image build for release-4.19
  • wget is not available in the build image, causing the ci/prow/image-images job to fail

Same fix as #80288 (release-4.18 and release-4.20), now applied to release-4.19.

Test plan

  • ci/prow/image-images job passes on openshift-tests-private PRs targeting release-4.19

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR adds a new CI configuration file for the OpenShift tests-private repository targeting the release-4.19 branch. The key change addresses a Docker image build failure in the tests-private-baseui image by replacing wget with curl when downloading the Google Chrome stable RPM during the build process.

Infrastructure Impact

The configuration adds CI job definitions for the openshift-tests-private repository's release-4.19 branch. In the tools image Dockerfile configuration, the Google Chrome installation step was updated to:

  • Use curl to download the RPM to a fixed filename (/tmp/google-chrome-stable_current_x86_64.rpm)
  • Install the downloaded RPM directly
  • Clean up the temporary file afterward

This replaces a wget-based approach that was causing the ci/prow/image-images job to fail, since wget is not available in the build image environment.

Rationale

This fix mirrors previously applied corrections to release-4.18 and release-4.20 branches (PR #80288), ensuring consistent image build reliability across multiple OpenShift release versions.

Replace wget with curl for Google Chrome RPM download in
tests-private-baseui image build. wget is not available in
the build image, causing the image build to fail.

This is the same fix as PR openshift#80288 applied to release-4.18
and release-4.20, now applied to release-4.19.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f73ce0cd-4a3e-4142-b4b3-6049a4e267ef

📥 Commits

Reviewing files that changed from the base of the PR and between 1dc08e5 and 874319f.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19.yaml

Walkthrough

This PR updates the CI configuration for OpenShift's private test suite to improve the Chrome RPM installation step in the tools image Dockerfile. The download method changes from wget with implicit glob matching to curl with an explicit target filename, making the installation process more deterministic.

Changes

Chrome RPM Download Update in CI Config

Layer / File(s) Summary
Chrome stable RPM download via curl with explicit filename
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19.yaml
Download step changed from wget to curl -fLo targeting /tmp/google-chrome-stable_current_x86_64.rpm explicitly, with install and cleanup aligned to the fixed filename instead of a glob pattern.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • sergiordlr
  • asood-rh
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing a DockerBuildFailed issue in the tests-private-baseui image for release-4.19, which is the core objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies a CI operator YAML configuration file with no Ginkgo test definitions. Custom check for test name stability is not applicable to build configuration files.
Test Structure And Quality ✅ Passed The PR modifies CI/CD configuration files (Dockerfile snippets in YAML), not Ginkgo test code. The custom check is designed for Ginkgo test quality review, making it inapplicable to this PR.
Microshift Test Compatibility ✅ Passed PR contains only Docker image build configuration changes (curl vs wget for Chrome RPM download), no new Ginkgo e2e tests. Check only applies when e2e tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies CI configuration YAML to fix Docker build by replacing wget with curl for Chrome RPM. No new Ginkgo e2e tests added; SNO check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies a CI operator config file (Dockerfile for test images), not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed This PR modifies CI configuration files (YAML) for Docker image builds, not OTE binary code. The check for OTE stdout contract violations is not applicable to build infrastructure changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies CI config YAML files only (replacing wget with curl for Chrome). No new Ginkgo e2e tests added, so IPv6/disconnected network check not applicable.
No-Weak-Crypto ✅ Passed PR modifies CI config file (wget→curl for Chrome). No weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) or custom implementations found. Uses SHA256 via standard sha256sum utility.
Container-Privileges ✅ Passed CI operator config with Dockerfile snippets, not K8s manifest. No privileged configurations (privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, root contexts) found.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data is exposed in logging. Both wget and curl commands use public Google URLs without credentials, API keys, or PII.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from asood-rh and memodi June 9, 2026 15:47
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@anuragthehatter: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-openshift-tests-private-release-4.19-bindata-check openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-code-check openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-disasterrecovery-metal-upi openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-winc-aws-upi openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-winc-azure-ipi openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-winc-gcp-ipi openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-winc-vsphere-ipi-disconnected openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-e2e-aws openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-e2e-console openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-images openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-release-4.19-title-check openshift/openshift-tests-private presubmit Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-stable-aws-ipi-shared-vpc-phz-sts-fips-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.18-metal-ds-ipi-ovn-ipv6-fips-f999 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-gcp-ipi-xpn-mini-perm-byo-hosted-zone-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-ipi-disc-oidc-oc-mirror-mini-perm-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-stable-aws-ipi-disc-priv-arm-mixarch-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-stable-aws-ipi-ovn-ipsec-to-multiarch-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-azure-ipi-ingress-controller-arm-mixarch-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-metal-upi-ovn-ipv4-compact-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-c2s-ipi-disc-priv-fips-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-ipi-proxy-tp-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.18-azure-ipi-confidential-trustedlaunch-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-gcp-ipi-labels-tags-filestore-csi-arm-f14 N/A periodic Ci-operator config changed

A total of 999 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rrasouli

rrasouli commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@anuragthehatter did you test with Podman?

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@anuragthehatter: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anuragthehatter

Copy link
Copy Markdown
Contributor Author

@rrasouli Yes, tested with Podman (v5.8.1) on UBI9:

$ podman run --rm registry.access.redhat.com/ubi9/ubi:latest bash -c \
  "curl -fLo /tmp/google-chrome-stable_current_x86_64.rpm https://dl.google.com/linux/direct/google-chrome-stable_current_x86_64.rpm && \
   ls -lh /tmp/google-chrome-stable_current_x86_64.rpm && echo SUCCESS"

-rw-r--r--. 1 root root 128M Jun  9 15:55 /tmp/google-chrome-stable_current_x86_64.rpm
SUCCESS

curl is available by default in UBI9 (unlike wget), so no additional package install is needed. This is the same approach used in PR #80288 for release-4.18 and release-4.20.

@rrasouli

rrasouli commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@pruan-rht

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anuragthehatter, pruan-rht, rrasouli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants