Skip to content

Add ARO-HCP dev shard2 and shard3 Boskos slot pools#80308

Open
raelga wants to merge 1 commit into
openshift:mainfrom
raelga:aro-hcp-onboard-shard2-shard3
Open

Add ARO-HCP dev shard2 and shard3 Boskos slot pools#80308
raelga wants to merge 1 commit into
openshift:mainfrom
raelga:aro-hcp-onboard-shard2-shard3

Conversation

@raelga

@raelga raelga commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Adds Boskos slot pools for two new ARO-HCP DEV E2E customer subscriptions (shard2, shard3), synced from test/e2e-config/e2e-slots.yaml in Azure/ARO-HCP via aro-hcp-tests slot-manager sync-boskos-config.

  • generate-boskos.py: registers aro-hcp-dev-shard2-slot and aro-hcp-dev-shard3-slot (1 slot each).
  • _boskos.yaml: regenerated (make boskos-config) — adds aro-hcp-dev-shard2-slot-00 and aro-hcp-dev-shard3-slot-00.

Validated with slot-manager validate-boskos-config against the slot catalog. Companion ARO-HCP PR: Azure/ARO-HCP#5576. Tracking: ARO-27549.

Summary by CodeRabbit

This pull request expands the Boskos resource pool configuration to support two new ARO-HCP DEV E2E test shards (shard2 and shard3). ARO-HCP is an Azure Red Hat OpenShift Hosted Control Plane offering, and these new shards represent additional isolated test environments for customer subscription E2E testing.

What changed:

  • generate-boskos.py: Updated the Boskos configuration to register two new slot resource types (aro-hcp-dev-shard2-slot and aro-hcp-dev-shard3-slot), each provisioning one slot resource
  • _boskos.yaml: Regenerated configuration file now includes the corresponding Boskos free resource entries for these new slots (aro-hcp-dev-shard2-slot-00 and aro-hcp-dev-shard3-slot-00)

Practical impact: The OpenShift CI infrastructure can now allocate test resources to the two new ARO-HCP DEV shards, enabling E2E testing for these additional customer subscription environments. The configuration was generated using the ARO-HCP slot-manager tool and validated against the slot catalog before submission.

Related: This syncs configuration from Azure/ARO-HCP repository (PR #5576) and tracks ARO-27549.

Onboard two new DEV E2E customer subscriptions (Dev-03, Dev-00) as
aro-hcp-dev-shard2-slot and aro-hcp-dev-shard3-slot (1 slot each),
synced from test/e2e-config/e2e-slots.yaml in Azure/ARO-HCP.
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dff02828-3b21-4448-91b0-69bcec492181

📥 Commits

Reviewing files that changed from the base of the PR and between a3b6beb and df19755.

📒 Files selected for processing (2)
  • core-services/prow/02_config/_boskos.yaml
  • core-services/prow/02_config/generate-boskos.py

Walkthrough

This PR adds two new ARO-HCP development resource slot types (shard2 and shard3) to the Boskos resource manager configuration. The generator script is updated to declare these new slot types and populate one resource for each, with the output reflected in the generated YAML configuration file.

Changes

ARO-HCP Shard2 and Shard3 Resource Slots

Layer / File(s) Summary
Generator script and YAML configuration for shard2/shard3 slots
core-services/prow/02_config/generate-boskos.py, core-services/prow/02_config/_boskos.yaml
Generator script CONFIG dictionary adds aro-hcp-dev-shard2-slot and aro-hcp-dev-shard3-slot quota-slice entries, resource population logic creates one resource for each new shard slot type, and the generated YAML output defines the two new free resources matching the script configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • openshift/release#80089: Both PRs modify core-services/prow/02_config/generate-boskos.py and the resulting core-services/prow/02_config/_boskos.yaml for aro-hcp-dev E2E slot type/resource generation (changing the set/naming of shard slot keys).
  • openshift/release#77407: Both PRs modify the same Boskos generation pipeline (core-services/prow/02_config/_boskos.yaml and core-services/prow/02_config/generate-boskos.py) by adding new ARO-HCP dev resource declarations produced by generate-boskos.py (though for different resource types: shard2/shard3 slots vs CD/image-push quota slices).

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • psalajova
  • jmguzik
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately summarizes the main change: adding ARO-HCP dev shard2 and shard3 Boskos slot pools.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check applies to Ginkgo test names. The PR modifies only Boskos configuration files (YAML) and Python generator script; no Ginkgo tests are present.
Test Structure And Quality ✅ Passed PR modifies YAML config and Python script for Boskos resource management, not Ginkgo test code. Check is not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies Boskos configuration files (_boskos.yaml and generate-boskos.py), not e2e tests. Check for Ginkgo test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added; PR only modifies Boskos configuration files (_boskos.yaml and generate-boskos.py), which are not test files. Check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds Boskos test infrastructure resource pool configurations only; no deployment manifests, operators, or scheduling constraints that could affect topology compatibility.
Ote Binary Stdout Contract ✅ Passed PR only modifies Boskos YAML configuration and Python generation script—no OTE binary test code present; check is inapplicable to configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds Boskos configuration files, not Ginkgo e2e tests. The custom check applies only to new e2e tests; therefore it is not applicable.
No-Weak-Crypto ✅ Passed No weak cryptography, custom crypto, or non-constant-time secret comparisons detected. PR only adds Boskos resource pool definitions.
Container-Privileges ✅ Passed PR only modifies Boskos resource configuration files and a Python generator script—no Kubernetes manifests or container specs present; check not applicable.
No-Sensitive-Data-In-Logs ✅ Passed PR introduces no new logging statements. Changes only add Boskos resource type definitions and slot names (non-sensitive identifiers).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raelga
Once this PR has been reviewed and has the lgtm label, please assign psalajova for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from Prucek and deepsm007 June 9, 2026 19:11
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@raelga: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@raelga: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant