Skip endpoint admission tests incompatible with managed clusters#80310
Skip endpoint admission tests incompatible with managed clusters#80310dustman9000 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughTwo ROSA conformance workflows are updated to expand their test skip patterns. HCP and STS configurations now include additional conformance test skips for admission-blocking manual creation of EndpointSlices and Endpoints resources. ChangesROSA Conformance Test Skip Patterns
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn periodic-ci-openshift-release-main-nightly-4.19-e2e-rosa-sts-ovn |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The [sig-network][endpoints] admission tests create ServiceAccounts in kube-system, which is blocked by the managed-cluster-validating-webhooks serviceaccount-validation webhook on ROSA clusters. The test user is not a system: prefixed user so the webhook correctly denies it. Skip these tests in both HCP and Classic STS conformance workflows.
dustman9000
force-pushed
the
fix/skip-endpoint-admission-managed
branch
from
2c21ddc to
e1fb94e
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@dustman9000: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
Skip two
[sig-network][endpoints]admission tests in both ROSA HCP and Classic STS conformance workflows.These tests create ServiceAccounts in
kube-system, which is blocked by themanaged-cluster-validating-webhooksserviceaccount-validationwebhook on ROSA clusters. The test user is not asystem:prefixed user, so the webhook correctly denies it.Tests skipped:
[sig-network][endpoints] admission blocks manual creation of EndpointSlices pointing to the cluster or service network[sig-network][endpoints] admission blocks manual creation of Endpoints pointing to the cluster or service networkFiles changed
ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yamlci-operator/step-registry/rosa/aws/sts/conformance/rosa-aws-sts-conformance-workflow.yamlSummary by CodeRabbit
This PR updates OpenShift CI configuration in the openshift/release repository to skip two conformance tests that are incompatible with managed ROSA clusters.
What changed:
Why:
Impact:
Additional notes: