Skip to content

chore: increase QCI pruner TTL to 60 days#80317

Open
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:fix/qci-pruner-ttl-60
Open

chore: increase QCI pruner TTL to 60 days#80317
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:fix/qci-pruner-ttl-60

Conversation

@deepsm007

@deepsm007 deepsm007 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/cc @jupierce @openshift/test-platform

https://redhat-internal.slack.com/archives/GB7NB0CUC/p1781030982393999?thread_ts=1778764637.570759&cid=GB7NB0CUC

Summary by CodeRabbit

This PR increases the default time-to-live (TTL) for the QCI registry pruner from 5 days to 60 days. The change affects OpenShift CI infrastructure's container image cleanup behavior, extending how long images are retained before automatic pruning.

Changes made:

  • Documentation (docs/dptp-triage-sop/qci-pruner-timeout.md): Updated all examples, command references, and the "Script Options" section to reflect the new 60-day default. Also revised the "Long-term Solutions" guidance from recommending TTL reduction to TTL adjustment.
  • Script implementation (hack/qci_registry_pruner.py): Updated the --ttl-days CLI argument default from 5 to 60 days.

The documentation and implementation are now consistent, ensuring that users and deployments follow the same extended retention policy.

@openshift-ci openshift-ci Bot requested review from a team and jupierce June 9, 2026 21:08
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@deepsm007: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: de946c6b-794c-4cca-8131-7ad5bbf7448b

📥 Commits

Reviewing files that changed from the base of the PR and between 1180812 and 7f2683c.

📒 Files selected for processing (2)
  • docs/dptp-triage-sop/qci-pruner-timeout.md
  • hack/qci_registry_pruner.py

Walkthrough

This PR increases the default time-to-live (TTL) for the QCI registry pruner from 5 days to 60 days. The script parameter is updated, and all documentation—including background explanations, command examples, and operational guidance—is synchronized to reflect the new default.

Changes

QCI Registry Pruner Default TTL Increase

Layer / File(s) Summary
Script CLI parameter update
hack/qci_registry_pruner.py
The --ttl-days argument default value is increased from 5 to 60, and help text is adjusted accordingly.
Documentation updates
docs/dptp-triage-sop/qci-pruner-timeout.md
Background section, Script Options reference, dry-run and production-run examples, extended backlog loop command, and Long-term Solutions recommendations are all updated to document and use the new 60-day default TTL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Suggested labels

ok-to-test

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: increasing the QCI pruner TTL from 5 to 60 days, which aligns directly with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only documentation and Python script changes; no Ginkgo tests are present or modified, making the test naming check not applicable.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code. Changes are limited to documentation (Markdown) and a Python script; custom check for test quality is not applicable.
Microshift Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests. It only updates documentation and a Python utility script for QCI pruner TTL. The MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests; it only updates documentation and a Python utility script. The SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies a Markdown documentation file and Python CLI script for registry tag pruning. No deployment manifests, operators, or scheduling constraints are present.
Ote Binary Stdout Contract ✅ Passed PR changes are not applicable to OTE Binary Stdout Contract check. The changes affect only a QCI registry utility script and documentation, not OTE test binaries that communicate via JSON stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests; it only modifies documentation and a Python utility script for QCI registry pruning. The check is not applicable.
No-Weak-Crypto ✅ Passed No weak cryptography detected. The PR changes container registry pruning TTL configuration with no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or non-constant-time comparisons.
Container-Privileges ✅ Passed PR modifies only documentation and a Python script; no container/K8s manifests with privilege configurations present.
No-Sensitive-Data-In-Logs ✅ Passed PR adds new files with TTL default 60 days. Code confirms NO sensitive data is logged—only tag names, counts, and error messages are logged safely.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant