Two snapshot tests fail consistently when run locally (npx vitest run tests/unit/snapshot.test.ts) on main (commit 6ef7dc6 and later):
tests/unit/snapshot.test.ts > snapshotSave > does not corrupt output when two --force saves race on the same name
tests/unit/snapshot.test.ts > snapshotSave > atomically rejects a concurrent non-force save when one already won
Both assert expect(fulfilled).toHaveLength(2) but get 0 — both concurrent save promises reject instead of one fulfilling.
Likely a race-related flake introduced or exposed by #1003 (TOCTOU close fix). Worth investigating whether something in the lock/lease handling is over-restrictive or platform-sensitive (macOS file system).
Surfaced while sweeping PR #1107; not caused by that PR.
Two snapshot tests fail consistently when run locally (
npx vitest run tests/unit/snapshot.test.ts) onmain(commit 6ef7dc6 and later):tests/unit/snapshot.test.ts > snapshotSave > does not corrupt output when two --force saves race on the same nametests/unit/snapshot.test.ts > snapshotSave > atomically rejects a concurrent non-force save when one already wonBoth assert
expect(fulfilled).toHaveLength(2)but get0— both concurrent save promises reject instead of one fulfilling.Likely a race-related flake introduced or exposed by #1003 (TOCTOU close fix). Worth investigating whether something in the lock/lease handling is over-restrictive or platform-sensitive (macOS file system).
Surfaced while sweeping PR #1107; not caused by that PR.