mingw: Fix unlink for open files

Fixes git#1653

Signed-off-by: Orgad Shaneh <orgads@gmail.com>

Author: orgads

compat/mingw.c

@@ -29,12 +29,17 @@
 #include <sspi.h>
 #include <wchar.h>
 #include <winioctl.h>
+#include <ktmw32.h>
 #include <winternl.h>
 
 #define STATUS_DELETE_PENDING ((NTSTATUS) 0xC0000056)
 
 #define HCAST(type, handle) ((type)(intptr_t)handle)
 
+#ifndef ERROR_TRANSACTIONAL_CONFLICT
+#define ERROR_TRANSACTIONAL_CONFLICT 6800
+#endif
+
 void open_in_gdb(void)
 {
 	static struct child_process cp = CHILD_PROCESS_INIT;
@@ -162,6 +167,7 @@ int err_win_to_posix(DWORD winerr)
 	case ERROR_WAIT_NO_CHILDREN: error = ECHILD; break;
 	case ERROR_WRITE_FAULT: error = EIO; break;
 	case ERROR_WRITE_PROTECT: error = EROFS; break;
+	case ERROR_TRANSACTIONAL_CONFLICT: error = EPERM; break;
 	}
 	return error;
 }
@@ -171,6 +177,7 @@ static inline int is_file_in_use_error(DWORD errcode)
 	switch (errcode) {
 	case ERROR_SHARING_VIOLATION:
 	case ERROR_ACCESS_DENIED:
+	case ERROR_TRANSACTIONAL_CONFLICT:
 		return 1;
 	}
 
@@ -531,6 +538,20 @@ static wchar_t *normalize_ntpath(wchar_t *wbuf)
 	return wbuf;
 }
 
+static int do_unlink(const wchar_t *wpathname)
+{
+#if _WIN32_WINNT >= 0x0600
+	HANDLE transaction = CreateTransaction(NULL, 0, 0, 0, 0, 0, NULL);
+	BOOL result = DeleteFileTransactedW(wpathname, transaction);
+	if (result)
+		CommitTransaction(transaction);
+	CloseHandle(transaction);
+	return result ? 0 : -1;
+#else
+	return _wunlink(wpathname);
+#endif
+}
+
 int mingw_unlink(const char *pathname, int handle_in_use_error)
 {
 	int tries = 0;
@@ -544,7 +565,7 @@ int mingw_unlink(const char *pathname, int handle_in_use_error)
 	do {
 		/* read-only files cannot be removed */
 		_wchmod(wpathname, 0666);
-		if (!_wunlink(wpathname))
+		if (!do_unlink(wpathname))
 			return 0;
 		if (!is_file_in_use_error(GetLastError()))
 			break;

config.mak.uname

@@ -733,7 +733,7 @@ ifeq ($(uname_S),MINGW)
 		compat/win32/pthread.o compat/win32/syslog.o \
 		compat/win32/dirent.o compat/win32/fscache.o compat/win32/wsl.o
 	BASIC_CFLAGS += -DWIN32
-	EXTLIBS += -lws2_32
+	EXTLIBS += -lws2_32 -lktmw32
 	GITLIBS += git.res
 	PTHREAD_LIBS =
 	RC = windres -O coff