Score Client Profiles - Remove program specific profiles

[joneubank]

Summary of request

The score client is designed to connect with any score and song servers, requiring only CLI arguments or configuration to specify the location of the storage (score) and metadata (song) servers that it will connect to. The current application.yml setup includes a pair of dedicated profiles for kf and oicr. We want to remove these profiles that provide specific hardcode connections, instead relying on the user to provide the URLs for the servers they intend to connect to.

In addition to profile specific hardcoded URLs, we will also remove the default values for storage and metadata server URLs.

Details

• Remove sections of the application.yml that refer to the kf and oicr profiles (keep debug)
• Remove default values for storage.url and metadata.url. Comment out the lines with these properties so it communicates that the application will look for these values but they are not provided by default.
  • Add or update documentation for users of the Score CLI to make it clear that the storage.url and metadata.url values need to be provided as command line arguments or through a configuration file.
• Remove the ProfileRepoValidator since it performs validations against specific project profile names. Remove all references to this class.
  • This class is only used by the function AbstractClientCommand.validateManifest(), and that function does nothing else. We can therefore also remove validateManifest() from the AbstractClientCommand and remove all references to it (occurs in a couple different commands).
• After removing the KF profile in Remove KF profile from score-client/storage/ScoreStorageService #460 , We can remove the Profile annotation in ScoreStorageService

  score/score-client/src/main/java/bio/overture/score/client/storage/score/ScoreStorageService.java

  Line 69 in f931ebe

  @Profile({"dev", "collab", "aws", "default", "!kf"})