Skip to content

Commit 704b0b6

Browse files
test: don't check for matching certs during renewal test
1 parent 4373ec2 commit 704b0b6

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsCertificateRenewTestCase.inc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,11 @@ class APIModelsCertificateRenewTestCase extends TestCase {
8686
}
8787

8888
/**
89-
* Ensure when we renew the Certificate while reusing the key and serial, both the certificate and
89+
* Ensure when we renew the Certificate while reusing the key and serial, both the serial and
9090
* the key remain the same.
9191
*/
9292
public function test_renew_certificate_reuse(): void {
9393
# Before we renew, obtain the existing CA cert
94-
$old_cert = $this->cert->crt->value;
9594
$old_key = $this->cert->prv->value;
9695

9796
# Renew the Certificate
@@ -107,8 +106,7 @@ class APIModelsCertificateRenewTestCase extends TestCase {
107106
# Refresh our CA object
108107
$this->cert = Certificate::query(refid: $this->cert->refid->value)->first();
109108

110-
# Ensure the certificate, key and serial are the same
111-
$this->assert_equals($old_cert, $this->cert->crt->value);
109+
# Ensure the key and serial are the same
112110
$this->assert_equals($old_key, $this->cert->prv->value);
113111
$this->assert_equals($renew->oldserial->value, $renew->newserial->value);
114112
}

0 commit comments

Comments
 (0)