From a5728cefb2c1dcdf943030a670872890966993e9 Mon Sep 17 00:00:00 2001 From: matthew-pilot Date: Thu, 28 May 2026 03:48:19 +0000 Subject: [PATCH] fix(dataexchange): emit event on WriteFrame failure in handleConn (PILOT-184) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When the ACK WriteFrame fails in handleConn, the loop silently returns — no metric, event, or log is surfaced. Operators have no visibility into ACK write failures on the wire. Fix: emit s.deps.Events.Publish("dataexchange.ack_failed", ...) with remote address, frame type, and error before returning. Matches the existing event-emission pattern used by file.received and message.received. --- service.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/service.go b/service.go index f669950..cb596b3 100644 --- a/service.go +++ b/service.go @@ -179,6 +179,13 @@ func (s *Service) handleConn(ctx context.Context, conn coreapi.Stream) { ackFrame = &Frame{Type: TypeText, Payload: []byte(ackMsg)} } if err := WriteFrame(conn, ackFrame); err != nil { + if s.deps.Events != nil { + s.deps.Events.Publish("dataexchange.ack_failed", map[string]any{ + "remote": conn.RemoteAddr(), + "frame_type": TypeName(frame.Type), + "error": err.Error(), + }) + } return } }