Skip to content

Commit 4ab86b0

Browse files
authored
Merge branch 'master' into master
2 parents 2d60b71 + a35ff7e commit 4ab86b0

27 files changed

Lines changed: 300 additions & 43 deletions

File tree

.github/workflows/trivy-security-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
uses: actions/checkout@v5
2121

2222
- name: Run Trivy vulnerability scanner
23-
uses: aquasecurity/trivy-action@0.33.1
23+
uses: aquasecurity/trivy-action@0.34.0
2424
with:
2525
scan-type: 'fs'
2626
scan-ref: '.'

extra/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<checkstyle.version>10.17.0</checkstyle.version>
3434

3535
<!-- Project production dependency versions -->
36-
<spring.boot.version>3.5.5</spring.boot.version>
36+
<spring.boot.version>3.5.10</spring.boot.version>
3737
<vertx.version>4.5.20</vertx.version>
3838
<validation-api.version>2.0.1.Final</validation-api.version>
3939
<commons.collections.version>4.4</commons.collections.version>

src/main/java/org/prebid/server/bidder/epsilon/EpsilonBidder.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.prebid.server.proto.openrtb.ext.response.BidType;
2828
import org.prebid.server.util.BidderUtil;
2929
import org.prebid.server.util.HttpUtil;
30+
import org.prebid.server.util.VersionInfo;
3031

3132
import java.math.BigDecimal;
3233
import java.util.ArrayList;
@@ -57,21 +58,23 @@ public class EpsilonBidder implements Bidder<BidRequest> {
5758
// Position of the ad as a relative measure of visibility or prominence
5859
private static final Set<Integer> AD_POSITIONS = IntStream.range(0, 8).boxed().collect(Collectors.toSet());
5960

60-
private static final String DISPLAY_MANAGER = "prebid-s2s";
61-
private static final String DISPLAY_MANAGER_VER = "2.0.0";
61+
private static final String DISPLAY_MANAGER = "prebid-s2s-java";
6262

6363
private final String endpointUrl;
6464
private final boolean generateBidId;
6565
private final JacksonMapper mapper;
66+
private final String displayManagerVersion;
6667

6768
public EpsilonBidder(String endpointUrl,
6869
boolean generateBidId,
70+
String pbsVersion,
6971
JacksonMapper mapper,
7072
CurrencyConversionService currencyConversionService) {
7173
this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl));
7274
this.generateBidId = generateBidId;
7375
this.mapper = Objects.requireNonNull(mapper);
7476
this.currencyConversionService = Objects.requireNonNull(currencyConversionService);
77+
this.displayManagerVersion = VersionInfo.UNDEFINED.equals(pbsVersion) ? null : pbsVersion;
7578
}
7679

7780
@Override
@@ -96,7 +99,7 @@ private BidRequest createOutgoingRequest(BidRequest bidRequest) {
9699
final BigDecimal bidFloor = resolveBidFloor(bidRequest,
97100
imp.getBidfloorcur(),
98101
getBidFloor(imp.getBidfloor(), impExt.getBidfloor()));
99-
modifiedImps.add(modifyImp(imp, impExt, bidFloor));
102+
modifiedImps.add(modifyImp(imp, impExt, bidFloor, displayManagerVersion));
100103
}
101104

102105
final Imp firstImp = requestImps.getFirst();
@@ -143,13 +146,13 @@ private static App updateApp(App app, String siteId) {
143146
return app == null ? null : app.toBuilder().id(siteId).build();
144147
}
145148

146-
private static Imp modifyImp(Imp imp, ExtImpEpsilon impExt, BigDecimal bidfloor) {
149+
private static Imp modifyImp(Imp imp, ExtImpEpsilon impExt, BigDecimal bidfloor, String displayManagerVersion) {
147150
final Banner banner = imp.getBanner();
148151
final Video video = imp.getVideo();
149152

150153
return imp.toBuilder()
151154
.displaymanager(DISPLAY_MANAGER)
152-
.displaymanagerver(DISPLAY_MANAGER_VER)
155+
.displaymanagerver(displayManagerVersion)
153156
.bidfloor(bidfloor)
154157
.bidfloorcur(BIDDER_CURRENCY)
155158
.tagid(getTagId(imp.getTagid(), impExt.getTagId()))

src/main/java/org/prebid/server/bidder/oms/OmsBidder.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,10 @@
3232

3333
public class OmsBidder implements Bidder<BidRequest> {
3434

35+
private static final String PUBLISHER_ID_MACRO = "{{PublisherId}}";
3536
private static final TypeReference<ExtPrebid<?, ExtImpOms>> EXT_TYPE_REFERENCE = new TypeReference<>() {
3637
};
38+
3739
private final String endpointUrl;
3840
private final JacksonMapper mapper;
3941

@@ -48,7 +50,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
4850
final ExtImpOms impExt = parseImpExt(request.getImp().getFirst());
4951
final String publisherId = resolverPublisherId(impExt.getPid(), impExt.getPublisherId());
5052
final String encodedPublisherId = HttpUtil.encodeUrl(publisherId);
51-
final String url = "%s?publisherId=%s".formatted(endpointUrl, encodedPublisherId);
53+
final String url = endpointUrl.replace(PUBLISHER_ID_MACRO, encodedPublisherId);
5254
return Result.withValue(BidderUtil.defaultRequest(request, url, mapper));
5355
} catch (PreBidException e) {
5456
return Result.withError(BidderError.badInput(e.getMessage()));

src/main/java/org/prebid/server/spring/config/bidder/EpsilonConfiguration.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler;
1212
import org.prebid.server.spring.config.bidder.util.UsersyncerCreator;
1313
import org.prebid.server.spring.env.YamlPropertySourceFactory;
14+
import org.prebid.server.util.VersionInfo;
1415
import org.springframework.beans.factory.annotation.Value;
1516
import org.springframework.boot.context.properties.ConfigurationProperties;
1617
import org.springframework.context.annotation.Bean;
@@ -36,6 +37,7 @@ EpsilonConfigurationProperties configurationProperties() {
3637
@Bean
3738
BidderDeps epsilonBidderDeps(EpsilonConfigurationProperties epsilonConfigurationProperties,
3839
@NotBlank @Value("${external-url}") String externalUrl,
40+
VersionInfo versionInfo,
3941
JacksonMapper mapper,
4042
CurrencyConversionService currencyConversionService) {
4143

@@ -46,6 +48,7 @@ BidderDeps epsilonBidderDeps(EpsilonConfigurationProperties epsilonConfiguration
4648
new EpsilonBidder(
4749
config.getEndpoint(),
4850
epsilonConfigurationProperties.getGenerateBidId(),
51+
versionInfo.getVersion(),
4952
mapper,
5053
currencyConversionService))
5154
.assemble();

src/main/java/org/prebid/server/util/VersionInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
public class VersionInfo {
1515

1616
private static final Logger logger = LoggerFactory.getLogger(VersionInfo.class);
17-
private static final String UNDEFINED = "undefined";
17+
public static final String UNDEFINED = "undefined";
1818

1919
String version;
2020
String commitHash;

src/main/resources/bidder-config/adkernel.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ adapters:
77
152media: ~
88
xapads:
99
enabled: false
10-
vendor-id: 1320
10+
meta-info:
11+
vendor-id: 1320
1112
usersync:
1213
enabled: true
1314
cookie-family-name: xapads

src/main/resources/bidder-config/flipp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
adapters:
22
flipp:
3-
endpoint: https://cdn-gateflipp.flippback.com/flyer-locator-service/prebid_campaigns
3+
endpoint: https://ads-flipp.com/flyer-locator-service/prebid_campaigns
44
meta-info:
55
maintainer-email: prebid@flipp.com
66
app-media-types:

src/main/resources/bidder-config/missena.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
adapters:
22
missena:
33
endpoint: https://bid.missena.io/?t={{PublisherID}}
4+
endpoint-compression: gzip
45
meta-info:
56
maintainer-email: prebid@missena.com
67
modifying-vast-xml-allowed: true
@@ -13,6 +14,6 @@ adapters:
1314
usersync:
1415
cookie-family-name: missena
1516
iframe:
16-
url: https://sync.missena.io/iframe?gdpr={{gdpr}}&consent={{gdpr_consent}}&us_privacy={{us_privacy}}&redirect={{redirect_url}}
17+
url: https://sync.missena.io/iframe?gdpr={{gdpr}}&consent={{gdpr_consent}}&us_privacy={{us_privacy}}&gpp={{gpp}}&gpp_sid={{gpp_sid}}&redirect={{redirect_url}}
1718
support-cors: false
1819
uid-macro: '$UID'

src/main/resources/bidder-config/mobilefuse.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ adapters:
1414
- video
1515
- native
1616
site-media-types:
17+
- banner
18+
- video
19+
- native
1720
supported-vendors:
1821
vendor-id: 909
1922
usersync:

0 commit comments

Comments
 (0)