Skip to content

[Phase 2] Testing - Modal, Inline, and Integration #42

@prosdev

Description

@prosdev

Description

Comprehensive testing for modal and inline plugins, plus integration tests with display conditions.

Tasks

Modal Plugin Tests:

  • Create packages/plugins/src/modal/modal.test.ts
  • Test modal rendering
  • Test focus trap (Tab, Shift+Tab)
  • Test keyboard handling (Escape)
  • Test backdrop click
  • Test ARIA attributes
  • Test multiple modals
  • Test cleanup on destroy
  • Test event emissions
  • Test mobile behavior
  • Test custom styles and className

Inline Plugin Tests:

  • Create packages/plugins/src/inline/inline.test.ts
  • Test content insertion
  • Test dismissal with persistence
  • Test selector not found handling
  • Test multiple inline experiences
  • Test cleanup on destroy
  • Test event emissions
  • Test custom styles

Integration Tests:

  • Add tests to packages/plugins/src/integration.test.ts
  • Test exit intent → modal
  • Test scroll depth → inline
  • Test page visits → modal
  • Test multiple layouts active simultaneously
  • Test modal + banner together
  • Test cleanup and memory

Acceptance Criteria

  • 20+ modal tests (100% coverage)
  • 15+ inline tests (100% coverage)
  • 10+ integration tests
  • All display conditions work with modal/inline
  • No memory leaks
  • No conflicts between layouts
  • All 350+ tests passing

Estimate: 1 day

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions