Fix not cleaning up on-demand temp files after failed download

fixes: #6975
(cherry picked from commit 0e52cd7)
Made-with: Cursor

Author: gerrod3

CHANGES/6975.bugfix

@@ -0,0 +1 @@
+Clean up on-demand temporary file left over on an aborted download.

pulpcore/content/handler.py

@@ -1156,8 +1156,10 @@ async def handle_data(data):
                 await original_handle_data(data)
 
         async def finalize():
+            nonlocal failed_download
             if save_artifact and remote.policy != Remote.STREAMED:
                 await original_finalize()
+            failed_download = False
 
         downloader = remote.get_downloader(
             remote_artifact=remote_artifact,
@@ -1167,6 +1169,7 @@ async def finalize():
         downloader.handle_data = handle_data
         original_finalize = downloader.finalize
         downloader.finalize = finalize
+        failed_download = True
         try:
             download_result = await downloader.run(
                 extra_data={"disable_retry_list": (DigestValidationError,)}
@@ -1193,6 +1196,13 @@ async def finalize():
                 "Learn more on <https://pulpproject.org/pulpcore/docs/user/learn/"
                 "on-demand-downloading/#on-demand-and-streamed-limitations>"
             )
+        finally:
+            if failed_download:
+                if downloader.path:
+                    await sync_to_async(os.unlink)(downloader.path)
+
+            if hasattr(downloader, "session"):
+                await downloader.session.close()
 
         if content_length := response.headers.get("Content-Length"):
             self._report_served_artifact_size(int(content_length))