[Bug]: 0.23.0 regression: `default: []` leads to ValidationError: "SchemaPath('…#default') is not of type 'array'"

[andersk]

Actual Behavior

A simple array parameter with a default value like this:

name: foo
in: query
schema:
  type: array
  default: []

leads to an error in 0.23.0:

Traceback (most recent call last):
  File "/home/anders/python/openapi-core/openapi_core/validation/decorators.py", line 31, in wrapper
    return f(*args, **kwds)
  File "/home/anders/python/openapi-core/openapi_core/validation/request/validators.py", line 208, in _get_parameter
    value, _ = self._get_param_or_header_and_schema(param, location)
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/anders/python/openapi-core/openapi_core/validation/validators.py", line 196, in _get_param_or_header_and_schema
    self._validate_schema(schema, casted)
    ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/anders/python/openapi-core/openapi_core/validation/validators.py", line 174, in _validate_schema
    validator.validate(value)
    ~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/home/anders/python/openapi-core/openapi_core/validation/schemas/validators.py", line 40, in validate
    raise InvalidSchemaValue(value, schema_type, schema_errors=errors)
openapi_core.validation.schemas.exceptions.InvalidSchemaValue: Value paths#/test#get#parameters#0#schema#default not valid for schema of type array: (<ValidationError: "SchemaPath('paths#/test#get#parameters#0#schema#default') is not of type 'array'">,)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/anders/python/openapi-core/default_test.py", line 25, in <module>
    spec.validate_request(request)
    ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/anders/python/openapi-core/openapi_core/app.py", line 564, in validate_request
    self.validate_apicall_request(request)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/anders/python/openapi-core/openapi_core/app.py", line 613, in validate_apicall_request
    self.request_validator.validate(request)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/anders/python/openapi-core/openapi_core/validation/request/validators.py", line 287, in validate
    raise err
  File "/home/anders/python/openapi-core/openapi_core/validation/request/validators.py", line 172, in _get_parameters
    value = self._get_parameter(parameters, param)
  File "/home/anders/python/openapi-core/openapi_core/validation/decorators.py", line 33, in wrapper
    self._raise_error(exc, self.err_validate_cls, f, *args, **kwds)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/anders/python/openapi-core/openapi_core/validation/decorators.py", line 58, in _raise_error
    raise init(**kw) from exc
openapi_core.validation.request.exceptions.InvalidParameter: Invalid query parameter: foo

Expected Behavior

No errors; this worked in 0.22.0.

Steps to Reproduce

from openapi_core import OpenAPI
from openapi_core.testing import MockRequest

spec = OpenAPI.from_dict(
    {
        "openapi": "3.1.0",
        "info": {"version": "0", "title": "Test"},
        "paths": {
            "/test": {
                "get": {
                    "parameters": [
                        {
                            "name": "foo",
                            "in": "query",
                            "schema": {"type": "array", "default": []},
                        }
                    ],
                    "responses": {"200": {"description": ""}},
                },
            }
        },
    }
)
request = MockRequest("http://localhost", "get", "/test")
spec.validate_request(request)

OpenAPI Core Version

0.23.0

OpenAPI Core Integration

MockRequest

Affected Area(s)

schema, validation

References

No response

Anything else we need to know?

• git bisect implicates commit 2e83cb9 “Upgrade jsonschema-path” (Upgrade jsonschema-path 0.4.0b8 and openapi-spec-validator 0.8.0b3 #1002).

Would you like to implement a fix?

None

[p1c2u]

@andersk thank you for the report. Te fix was merged.