Skip to content

Commit 52ef2e2

Browse files
committed
merge benchmark ids from differend sources don't override
1 parent 68d958c commit 52ef2e2

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

codespeed/views.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -366,12 +366,14 @@ def comparison(request):
366366
benchmarks[source_label] = qs
367367
for unit in qs.values_list('units_title', flat=True).distinct():
368368
unit_qs = qs.filter(units_title=unit)
369-
units = unit_qs[0].units
370-
lessisbetter = (unit_qs[0].lessisbetter and
371-
' (less is better)' or ' (more is better)')
372-
bench_units[unit] = [
373-
[b.id for b in unit_qs], lessisbetter, units
374-
]
369+
ids = [b.id for b in unit_qs]
370+
if unit in bench_units:
371+
bench_units[unit][0].extend(ids)
372+
else:
373+
units = unit_qs[0].units
374+
lessisbetter = (unit_qs[0].lessisbetter and
375+
' (less is better)' or ' (more is better)')
376+
bench_units[unit] = [ids, lessisbetter, units]
375377
checkedbenchmarks = []
376378
if 'ben' in data:
377379
checkedbenchmarks = _parse_ben_param(data['ben'])

0 commit comments

Comments
 (0)