address review: add assert on _PY_IS_SMALL_INT

skirpichev · skirpichev · commit 0b29e28567f5 · 2026-03-31T02:53:30.000+03:00
diff --git a/Include/internal/pycore_long.h b/Include/internal/pycore_long.h
@@ -240,6 +240,9 @@ _PyLong_HasImmortalTag(const PyLongObject *op)
     bool is_small_int = (op->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;
     assert(PyLong_CheckExact(op) || (!is_small_int));
     assert(_Py_IsImmortal(op) || (!is_small_int));
+    assert((_PyLong_IsCompact(op)
+            && _PY_IS_SMALL_INT(_PyLong_CompactValue(op)))
+           || (!is_small_int));
     return is_small_int;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -240,6 +240,9 @@ _PyLong_HasImmortalTag(const PyLongObject *op)`
`240`	`240`	`bool is_small_int = (op->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;`
`241`	`241`	`assert(PyLong_CheckExact(op) \|\| (!is_small_int));`
`242`	`242`	`assert(_Py_IsImmortal(op) \|\| (!is_small_int));`
	`243`	`+ assert((_PyLong_IsCompact(op)`
	`244`	`+ && _PY_IS_SMALL_INT(_PyLong_CompactValue(op)))`
	`245`	`+ \|\| (!is_small_int));`
`243`	`246`	`return is_small_int;`
`244`	`247`	`}`
`245`	`248`