Skip to content

Commit 1175471

Browse files
Remove runtime zlib-ng versions which are not available in compat mode.
1 parent 76354de commit 1175471

5 files changed

Lines changed: 2 additions & 43 deletions

File tree

Doc/library/zlib.rst

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -526,14 +526,6 @@ the module:
526526

527527
.. versionadded:: 3.14
528528

529-
.. data:: zlibng_version
530-
531-
The version string of the zlib-ng library actually loaded
532-
by the interpreter.
533-
534-
.. versionadded:: next
535-
536-
537529
.. data:: ZLIBNG_VERSION_INFO
538530

539531
A named tuple containing the version of the zlib-ng library that was
@@ -542,14 +534,6 @@ the module:
542534
.. versionadded:: next
543535

544536

545-
.. data:: zlibng_version_info
546-
547-
A named tuple containing the zlib-ng library version actually loaded
548-
by the interpreter.
549-
550-
.. versionadded:: next
551-
552-
553537
.. seealso::
554538

555539
Module :mod:`gzip`

Doc/whatsnew/3.16.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,7 @@ zlib
150150
----
151151

152152
* Added constants :const:`~zlib.ZLIB_VERSION_INFO`,
153-
:const:`~zlib.zlib_version_info`, :const:`~zlib.zlibng_version`,
154-
:const:`~zlib.ZLIBNG_VERSION_INFO`, and :const:`~zlib.zlibng_version_info`,
153+
:const:`~zlib.zlib_version_info`, and :const:`~zlib.ZLIBNG_VERSION_INFO`,
155154
which provide information about the version of the zlib and the zlib-ng
156155
libraries in use.
157156
Added :const:`~zlib.zlib_version` as an alias of

Lib/test/pythoninfo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ def collect_zlib(info_add):
660660
except ImportError:
661661
return
662662

663-
attributes = ('ZLIB_VERSION', 'zlib_version', 'ZLIBNG_VERSION', 'zlibng_version')
663+
attributes = ('ZLIB_VERSION', 'zlib_version', 'ZLIBNG_VERSION')
664664
copy_attributes(info_add, zlib, 'zlib.%s', attributes)
665665

666666

Lib/test/test_zlib.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,6 @@ def test_library_version(self):
7272
zlib.ZLIB_VERSION.split('.')[0])
7373
self.assertEqual(zlib.zlib_version_info[0],
7474
zlib.ZLIB_VERSION_INFO[0])
75-
if hasattr(zlib, 'ZLIBNG_VERSION'):
76-
self.assertEqual(zlib.zlibng_version.split('.')[0],
77-
zlib.ZLIBNG_VERSION.split('.')[0])
78-
self.assertEqual(zlib.zlibng_version_info[0],
79-
zlib.ZLIBNG_VERSION_INFO[0])
80-
else:
81-
self.assertNotHasAttr(zlib, 'ZLIBNG_VERSION')
82-
self.assertNotHasAttr(zlib, 'zlibng_version')
83-
self.assertNotHasAttr(zlib, 'ZLIBNG_VERSION_INFO')
84-
self.assertNotHasAttr(zlib, 'zlibng_version_info')
8575

8676
def _test_zlib_version(self, v):
8777
self.assertIsInstance(v[:], tuple)
@@ -135,13 +125,9 @@ def _test_zlibng_version(self, v):
135125
def test_zlibng_version(self):
136126
if support.verbose:
137127
print(f'ZLIBNG_VERSION = {zlib.ZLIBNG_VERSION}', flush=True)
138-
print(f'zlibng_version = {zlib.zlibng_version}', flush=True)
139128
print(f'ZLIBNG_VERSION_INFO = {zlib.ZLIBNG_VERSION_INFO}', flush=True)
140-
print(f'zlibng_version_info = {zlib.zlibng_version_info}', flush=True)
141129
self._test_zlibng_version(zlib.ZLIBNG_VERSION_INFO)
142130
self.assertEqual(zlib.ZLIBNG_VERSION, '%d.%d.%d' % zlib.ZLIBNG_VERSION_INFO)
143-
self._test_zlibng_version(zlib.zlibng_version_info)
144-
self.assertEqual(zlib.zlibng_version, '%d.%d.%d' % zlib.zlibng_version_info)
145131

146132

147133
class ChecksumTestCase(unittest.TestCase):

Modules/zlibmodule.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2375,10 +2375,6 @@ zlib_exec(PyObject *mod)
23752375
PyUnicode_FromString(ZLIBNG_VERSION)) < 0) {
23762376
return -1;
23772377
}
2378-
if (PyModule_Add(mod, "zlibng_version",
2379-
PyUnicode_FromString(zlibng_version())) < 0) {
2380-
return -1;
2381-
}
23822378
#endif
23832379
PyTypeObject *version_type;
23842380
version_type = PyStructSequence_NewType(&zlib_version_desc);
@@ -2409,12 +2405,6 @@ zlib_exec(PyObject *mod)
24092405
Py_DECREF(version_type);
24102406
return -1;
24112407
}
2412-
if (PyModule_Add(mod, "zlibng_version_info",
2413-
make_zlibng_version(version_type, zlibng_version())) < 0)
2414-
{
2415-
Py_DECREF(version_type);
2416-
return -1;
2417-
}
24182408
Py_DECREF(version_type);
24192409
#endif
24202410
return 0;

0 commit comments

Comments
 (0)