Commit 6d58cdc
committed
Address review feedback from @nedbat and @ZeroIntensity
- Shorten hint format to "Did you mean '.append'?" (drop redundant
"instead of '.push'" since the error already names the attribute)
- Add dict.put and list.contains entries suggesting language constructs
(dict[key] = value, x in list) per @ZeroIntensity's review
- Replace suppress(Exception) with direct call (function is safe)
- Link to GH issue instead of Discourse thread in comment
- Drop column alignment in hint table entries
- Trim NEWS entry last sentence1 parent aecaacb commit 6d58cdc
File tree
3 files changed
+28
-19
lines changed- Lib
- test
- Misc/NEWS.d/next/Library
3 files changed
+28
-19
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4567 | 4567 | | |
4568 | 4568 | | |
4569 | 4569 | | |
| 4570 | + | |
4570 | 4571 | | |
4571 | 4572 | | |
4572 | 4573 | | |
| |||
4576 | 4577 | | |
4577 | 4578 | | |
4578 | 4579 | | |
| 4580 | + | |
| 4581 | + | |
| 4582 | + | |
| 4583 | + | |
4579 | 4584 | | |
4580 | 4585 | | |
4581 | 4586 | | |
| |||
4608 | 4613 | | |
4609 | 4614 | | |
4610 | 4615 | | |
| 4616 | + | |
| 4617 | + | |
| 4618 | + | |
| 4619 | + | |
4611 | 4620 | | |
4612 | 4621 | | |
4613 | 4622 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1154 | 1154 | | |
1155 | 1155 | | |
1156 | 1156 | | |
1157 | | - | |
1158 | | - | |
1159 | | - | |
1160 | | - | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
1161 | 1160 | | |
1162 | 1161 | | |
1163 | 1162 | | |
| |||
1669 | 1668 | | |
1670 | 1669 | | |
1671 | 1670 | | |
1672 | | - | |
| 1671 | + | |
1673 | 1672 | | |
1674 | 1673 | | |
1675 | | - | |
1676 | | - | |
| 1674 | + | |
| 1675 | + | |
1677 | 1676 | | |
1678 | | - | |
| 1677 | + | |
| 1678 | + | |
1679 | 1679 | | |
1680 | 1680 | | |
1681 | | - | |
| 1681 | + | |
1682 | 1682 | | |
1683 | 1683 | | |
1684 | 1684 | | |
1685 | | - | |
1686 | | - | |
| 1685 | + | |
| 1686 | + | |
1687 | 1687 | | |
1688 | | - | |
1689 | | - | |
1690 | | - | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
1691 | 1692 | | |
1692 | 1693 | | |
1693 | 1694 | | |
| |||
1768 | 1769 | | |
1769 | 1770 | | |
1770 | 1771 | | |
1771 | | - | |
1772 | | - | |
| 1772 | + | |
| 1773 | + | |
1773 | 1774 | | |
1774 | 1775 | | |
1775 | 1776 | | |
| |||
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
| 3 | + | |
| 4 | + | |
0 commit comments