Skip to content

Commit 7eeccba

Browse files
committed
Iterate list_of_data once in writelines per review
1 parent ce68375 commit 7eeccba

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

Lib/asyncio/selector_events.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1194,8 +1194,11 @@ def writelines(self, list_of_data):
11941194
self._conn_lost += 1
11951195
return
11961196

1197-
self._buffer_size += sum(len(data) for data in list_of_data)
1198-
self._buffer.extend([memoryview(data) for data in list_of_data])
1197+
views = []
1198+
for data in list_of_data:
1199+
views.append(memoryview(data))
1200+
self._buffer_size += len(data)
1201+
self._buffer.extend(views)
11991202
self._write_ready()
12001203
# If the entire buffer couldn't be written, register a write handler
12011204
if self._buffer:

0 commit comments

Comments
 (0)