Skip to content

Commit ace5d7c

Browse files
Fix possible memory leak
1 parent 70affe0 commit ace5d7c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Objects/odictobject.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1168,8 +1168,10 @@ OrderedDict_popitem_impl(PyODictObject *self, int last)
11681168
node = last ? _odict_LAST(self) : _odict_FIRST(self);
11691169
key = Py_NewRef(_odictnode_KEY(node));
11701170
value = _odict_popkey_hash((PyObject *)self, key, NULL, _odictnode_HASH(node));
1171-
if (value == NULL)
1171+
if (value == NULL) {
1172+
Py_DECREF(key);
11721173
return NULL;
1174+
}
11731175
item = PyTuple_Pack(2, key, value);
11741176
Py_DECREF(key);
11751177
Py_DECREF(value);

0 commit comments

Comments
 (0)