s/ndjson/jsonl/

Author: maurycy

Lib/profiling/sampling/__init__.py

@@ -9,7 +9,7 @@
 from .stack_collector import CollapsedStackCollector
 from .heatmap_collector import HeatmapCollector
 from .gecko_collector import GeckoCollector
-from .ndjson_collector import NdjsonCollector
+from .jsonl_collector import JsonlCollector
 from .string_table import StringTable
 
 __all__ = (
@@ -18,6 +18,6 @@
     "CollapsedStackCollector",
     "HeatmapCollector",
     "GeckoCollector",
-    "NdjsonCollector",
+    "JsonlCollector",
     "StringTable",
 )

Lib/profiling/sampling/binary_reader.py

@@ -4,7 +4,7 @@
 
 from .gecko_collector import GeckoCollector
 from .stack_collector import FlamegraphCollector, CollapsedStackCollector
-from .ndjson_collector import NdjsonCollector
+from .jsonl_collector import JsonlCollector
 from .pstats_collector import PstatsCollector
 
 
@@ -118,8 +118,8 @@ def convert_binary_to_format(input_file, output_file, output_format,
             collector = PstatsCollector(interval)
         elif output_format == 'gecko':
             collector = GeckoCollector(interval)
-        elif output_format == 'ndjson':
-            collector = NdjsonCollector(interval)
+        elif output_format == 'jsonl':
+            collector = JsonlCollector(interval)
         else:
             raise ValueError(f"Unknown output format: {output_format}")
 

Lib/profiling/sampling/cli.py

@@ -19,7 +19,7 @@
 from .stack_collector import CollapsedStackCollector, FlamegraphCollector
 from .heatmap_collector import HeatmapCollector
 from .gecko_collector import GeckoCollector
-from .ndjson_collector import NdjsonCollector
+from .jsonl_collector import JsonlCollector
 from .binary_collector import BinaryCollector
 from .binary_reader import BinaryReader
 from .constants import (
@@ -88,7 +88,7 @@ class CustomFormatter(
     "flamegraph": "html",
     "gecko": "json",
     "heatmap": "html",
-    "ndjson": "ndjson",
+    "jsonl": "jsonl",
     "binary": "bin",
 }
 
@@ -98,7 +98,7 @@ class CustomFormatter(
     "flamegraph": FlamegraphCollector,
     "gecko": GeckoCollector,
     "heatmap": HeatmapCollector,
-    "ndjson": NdjsonCollector,
+    "jsonl": JsonlCollector,
     "binary": BinaryCollector,
 }
 
@@ -471,11 +471,11 @@ def _add_format_options(parser, include_compression=True, include_binary=True):
         help="Generate interactive HTML heatmap visualization with line-level sample counts",
     )
     format_group.add_argument(
-        "--ndjson",
+        "--jsonl",
         action="store_const",
-        const="ndjson",
+        const="jsonl",
         dest="format",
-        help="Generate NDJSON snapshot output for external consumers",
+        help="Generate JSONL snapshot output for external consumers",
     )
     if include_binary:
         format_group.add_argument(
@@ -560,7 +560,7 @@ def _create_collector(format_type, sample_interval_usec, skip_idle, opcodes=Fals
 
     Args:
         format_type: The output format ('pstats', 'collapsed', 'flamegraph',
-                    'gecko', 'heatmap', 'ndjson', 'binary')
+                    'gecko', 'heatmap', 'jsonl', 'binary')
         sample_interval_usec: Sampling interval in microseconds
         skip_idle: Whether to skip idle samples
         opcodes: Whether to collect opcode information (only used by gecko format
@@ -589,7 +589,7 @@ def _create_collector(format_type, sample_interval_usec, skip_idle, opcodes=Fals
         skip_idle = False
         return collector_class(sample_interval_usec, skip_idle=skip_idle, opcodes=opcodes)
 
-    if format_type == "ndjson":
+    if format_type == "jsonl":
         return collector_class(
             sample_interval_usec, skip_idle=skip_idle, mode=mode
         )

…b/profiling/sampling/ndjson_collector.py Lib/profiling/sampling/jsonl_collector.pyLib/profiling/sampling/ndjson_collector.py renamed to Lib/profiling/sampling/jsonl_collector.py Lib/profiling/sampling/ndjson_collector.py renamed to Lib/profiling/sampling/jsonl_collector.py

@@ -1,4 +1,4 @@
-"""NDJSON collector."""
+"""JSONL collector."""
 
 import json
 import uuid
@@ -25,8 +25,8 @@
 }
 
 
-class NdjsonCollector(StackTraceCollector):
-    """Collector that exports finalized profiling data as NDJSON."""
+class JsonlCollector(StackTraceCollector):
+    """Collector that exports finalized profiling data as JSONL."""
 
     def __init__(self, sample_interval_usec, *, skip_idle=False, mode=None):
         super().__init__(sample_interval_usec, skip_idle=skip_idle)
@@ -81,7 +81,7 @@ def export(self, filename):
                 },
             )
 
-        print(f"NDJSON profile written to {filename}")
+        print(f"JSONL profile written to {filename}")
 
     def _build_meta_record(self):
         record = {