-
Notifications
You must be signed in to change notification settings - Fork 131
Open
Description
- For some reasons instead of comparing against the latest
main(or at leastv5.0.0),codecovis pinned to 60e928f (example 1, example 2). - The
codecovbot prematurely writes the comment (before all the tests are run on all platforms) and only later edits it, and triggers transient false alarms for coverage failure. - There are duplicate/empty
Codecov Uploadjob steps in thebuild_binpy_wheelsjob (example):- The first one is skipped because
${{ secrets.CODECOV_TOKEN }}is undefined. - The second one reports that no coverage files are found (because
cibuildwheeldoesn't doesn't runpytestwithcoverage) and that it thusFailed to run upload-coverage. (This however doesn't cause the pipeline to fail.)- This begs the question, should be make CI fail if
codecov-actionfails (we can use thefail_ci_if_errorswitch for that)?
- This begs the question, should be make CI fail if
- The first one is skipped because
- The
Codecov Uploadjob step issues a warning because thefileparameter has been superseded byfiles.
Metadata
Metadata
Assignees
Labels
No labels