Skip to content

Use SPDX license metadata#1347

Merged
mhucka merged 2 commits into
quantumlib:mainfrom
BeauDevCode:chore/spdx-license-metadata-1346
Jun 9, 2026
Merged

Use SPDX license metadata#1347
mhucka merged 2 commits into
quantumlib:mainfrom
BeauDevCode:chore/spdx-license-metadata-1346

Conversation

@BeauDevCode

@BeauDevCode BeauDevCode commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Updates setup.py to use the Apache-2.0 SPDX license expression.
  • Keeps the License :: OSI Approved :: Apache Software License PyPI classifier for downstream compatibility and license-scanner support.

Validation:

  • python setup.py --license - returned Apache-2.0.
  • GitHub CI checks are currently passing.

Related issue:

Risk:

  • Low; packaging metadata-only change with no runtime code changes.

Update setup.py to use the Apache-2.0 SPDX expression and remove the deprecated license classifier.
@google-cla

google-cla Bot commented Jun 8, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@BeauDevCode BeauDevCode marked this pull request as ready for review June 8, 2026 05:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the license string in setup.py to 'Apache-2.0' and removes the corresponding PyPI classifier. Feedback suggests retaining the 'License :: OSI Approved :: Apache Software License' classifier, as removing it can break downstream package consumers and automated compliance scanners that rely on standard PyPI classifiers.

Comment thread setup.py
Comment on lines 67 to 68
'Intended Audience :: Science/Research',
'License :: OSI Approved :: Apache Software License',
'Operating System :: MacOS',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing the License :: OSI Approved :: Apache Software License classifier can break downstream package consumers and automated compliance scanners. Many enterprise dependency analysis tools and security scanners rely strictly on standard PyPI classifiers to verify license compliance. Removing this classifier can cause the package to be flagged as having an "unspecified" or "unknown" license. Additionally, PyPI's search and filtering features still rely on these classifiers. It is highly recommended to retain this classifier alongside the updated license field.

Suggested change
'Intended Audience :: Science/Research',
'License :: OSI Approved :: Apache Software License',
'Operating System :: MacOS',
'Intended Audience :: Science/Research',
'License :: OSI Approved :: Apache Software License',
'Operating System :: MacOS',

@mhucka mhucka self-assigned this Jun 9, 2026
@mhucka mhucka added the area/health Involves code and/or project health label Jun 9, 2026
@mhucka

mhucka commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

@BeauDevCode Thank you for this contribution!

@mhucka mhucka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mhucka mhucka added this pull request to the merge queue Jun 9, 2026
@mhucka

mhucka commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1347.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 9, 2026
@mhucka mhucka added this pull request to the merge queue Jun 9, 2026
Merged via the queue into quantumlib:main with commit 1ffac0a Jun 9, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/health Involves code and/or project health

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change license classifier in setup.py to use SPDX license term

2 participants