Use SPDX license metadata#1347
Conversation
Update setup.py to use the Apache-2.0 SPDX expression and remove the deprecated license classifier.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the license string in setup.py to 'Apache-2.0' and removes the corresponding PyPI classifier. Feedback suggests retaining the 'License :: OSI Approved :: Apache Software License' classifier, as removing it can break downstream package consumers and automated compliance scanners that rely on standard PyPI classifiers.
| 'Intended Audience :: Science/Research', | ||
| 'License :: OSI Approved :: Apache Software License', | ||
| 'Operating System :: MacOS', |
There was a problem hiding this comment.
Removing the License :: OSI Approved :: Apache Software License classifier can break downstream package consumers and automated compliance scanners. Many enterprise dependency analysis tools and security scanners rely strictly on standard PyPI classifiers to verify license compliance. Removing this classifier can cause the package to be flagged as having an "unspecified" or "unknown" license. Additionally, PyPI's search and filtering features still rely on these classifiers. It is highly recommended to retain this classifier alongside the updated license field.
| 'Intended Audience :: Science/Research', | |
| 'License :: OSI Approved :: Apache Software License', | |
| 'Operating System :: MacOS', | |
| 'Intended Audience :: Science/Research', | |
| 'License :: OSI Approved :: Apache Software License', | |
| 'Operating System :: MacOS', |
|
@BeauDevCode Thank you for this contribution! |
|
Fixes #1347. |
Summary:
setup.pyto use theApache-2.0SPDX license expression.License :: OSI Approved :: Apache Software LicensePyPI classifier for downstream compatibility and license-scanner support.Validation:
python setup.py --license- returnedApache-2.0.Related issue:
Risk: