Skip to content

Replace noninclusive dummy and sanity language (#1290)#1348

Merged
mhucka merged 2 commits into
quantumlib:mainfrom
rosspeili:inclusive-language-1290
Jun 9, 2026
Merged

Replace noninclusive dummy and sanity language (#1290)#1348
mhucka merged 2 commits into
quantumlib:mainfrom
rosspeili:inclusive-language-1290

Conversation

@rosspeili

@rosspeili rosspeili commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Comment and docstring edits per Khronos guidance, following quantumlib/Cirq#8120. No API or behavior changes. Intentionally leaves pylint option names and Sphinx config unchanged.

Closes #1290

Comment and docstring edits per Khronos guidance, following quantumlib/Cirq#8120. No API or behavior changes. Intentionally leaves pylint option names and Sphinx config unchanged.
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors comments and docstrings across various files to replace terms like 'sanity check' and 'dummy' with more precise and inclusive terminology such as 'validate', 'check', 'placeholder', 'unused', and 'edge-case'. There are no review comments, so I have no feedback to provide.

@mhucka mhucka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks!

@mhucka mhucka added this pull request to the merge queue Jun 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 9, 2026
@mhucka mhucka enabled auto-merge June 9, 2026 06:00
@mhucka mhucka added this pull request to the merge queue Jun 9, 2026
Merged via the queue into quantumlib:main with commit 2d853dd Jun 9, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove offensive terms from the code base

2 participants