Fix mypy annotations in fermion_partitioning (#1282)#1349
Open
rosspeili wants to merge 1 commit into
Open
Conversation
First slice for quantumlib#1282: correct generator return types and local variable annotations in measurements/fermion_partitioning.py. No runtime or API behavior changes.
mhucka
requested changes
Jun 9, 2026
mhucka
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for doing this!
There is one change I would recommend. Although Any is valid, it is better to define so-called generic parameter types, along the following lines:
from typing import TypeVar
T = TypeVar('T')
def pair_within(labels: list[T]) -> Generator[tuple[T, ...], None, None]:
"""Generates pairings of labels that contain each pair at least once."""
...Applying this across other matching functions (like pair_between and pair_within_simultaneously) allows static analyzers to check that the output tuples contain elements of the exact same type as the input.
Would you be able to try to make the appropriate changes to this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice for #1282: correct generator return types and local variable annotations in measurements/fermion_partitioning.py. No runtime or API behavior changes.