Formatting fixes

Author: louispt1

app/controllers/api/v3/export_controller.rb

@@ -28,7 +28,8 @@ def energy_flow
       #
       # Returns a CSV file containing the energetic inputs and outputs of every node in the present graph.
       def energy_flow_present
-        send_csv(NodeFlowSerializer.new(@scenario.gql.present.graph, 'MJ'), 'energy_flow_present.%d.csv')
+        send_csv(NodeFlowSerializer.new(@scenario.gql.present.graph, 'MJ'),
+          'energy_flow_present.%d.csv')
       end
 
       # GET /api/v3/scenarios/:id/molecule_flow

app/models/qernel/node_api/direct_bio_emissions.rb

@@ -145,7 +145,7 @@ def direct_edge_bio_carbon_content(edge)
           return composition if composition
         end
 
-        nil # TODO: consider this case
+        0.0 # TODO: consider this case
       end
     end
   end

app/models/qernel/node_api/direct_emissions.rb

@@ -135,7 +135,7 @@ def direct_edge_carbon_content(edge)
           return composition if composition
         end
 
-        nil # TODO: consider this case
+        0.0
       end
     end
   end

app/serializers/emissions_export_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Presents comprehensive emission data including gross, captured, and net emissions
 # for both fossil and biogenic CO2, plus other GHG emissions.
 class EmissionsExportSerializer
@@ -20,7 +22,7 @@ def as_csv(*)
 
       nodes.each do |node|
         row = node_row(node)
-        csv << row if row  # Only include valid rows (skip nil)
+        csv << row if row # Only include valid rows (skip nil)
       end
     end
   end
@@ -42,19 +44,17 @@ def header_row
   def nodes
     # Include all energy nodes that have emissions or are final demand nodes
     @graph.nodes.select do |node|
-      has_emissions?(node) || node.groups.include?(:final_demand)
+      emissions?(node) || node.groups.include?(:final_demand)
     end.sort_by(&:key)
   end
 
-  def has_emissions?(node)
+  def emissions?(node)
     node.query.direct_co2_emission_of_fossil_gross.positive? ||
       node.query.direct_co2_emission_of_bio_gross.positive?
   rescue StandardError => e
     # Nodes without DirectEmissions module (e.g., molecule graph nodes) will raise NoMethodError
     # This is expected and we silently exclude them
-    Rails.logger.debug(
-      "Emissions check failed for #{node.key}: #{e.class.name} - #{e.message}"
-    )
+    Rails.logger.debug { "Emissions check failed for #{node.key}: #{e.class.name} - #{e.message}" }
     false
   end
 
@@ -78,7 +78,7 @@ def node_row(node)
     co2_production = to_kton(fossil_gross)
     co2_capture = to_kton(fossil_captured + bio_captured)
 
-    # Column 3: Other GHG emissions (CH4, N2O, etc. - currently 0, future: AREA attributes)
+    # TODO: Column 3: Other GHG emissions (CH4, N2O, etc. - currently 0, future: AREA attributes)
     other_ghg = 0.0
 
     # Column 4: Total GHG emissions = production - capture + other
@@ -88,9 +88,8 @@ def node_row(node)
     bio_net = safe_query(node, :direct_co2_emission_of_bio)
     biogenic = bio_net.nil? ? nil : to_kton(bio_net)
 
-    # Column 6: CO2 emissions end-use allocation (primary emissions)
-    primary_fossil = safe_query(node, :primary_co2_emission_of_fossil)
-    end_use_allocation = primary_fossil.nil? ? nil : to_kton(primary_fossil)
+    # TODO: Column 6: CO2 emissions end-use allocation (PLACEHOLDER)
+    end_use_allocation = 0.0
 
     [
       node.key,
@@ -147,6 +146,7 @@ def format_value(value)
     end
 
     return '0' if value.abs < 0.000001  # 1 kg
+
     value.to_s
   end
 end

spec/controllers/api/v3/exports_controller_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Api::V3::ExportController do
-  let(:scenario) { FactoryBot.create(:scenario) }
+  let(:scenario) { create(:scenario) }
   let(:user) { create(:user) }
   let(:headers) { access_token_header(user, :write) }
 

spec/models/qernel/edge_api_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper'
 
 RSpec.describe Qernel::NodeApi::Base do
-  let(:supplier) { FactoryBot.build(:node, key: :supplier) }
-  let(:consumer) { FactoryBot.build(:node, key: :consumer) }
+  let(:supplier) { build(:node, key: :supplier) }
+  let(:consumer) { build(:node, key: :consumer) }
   let(:carrier)  { Qernel::Carrier.new(key: :network_gas) }
   let!(:edge)    { Qernel::Edge.new('', consumer, supplier, carrier, :share) }
 

spec/models/qernel/node_api/direct_emissions_spec.rb

@@ -113,7 +113,6 @@
       end
     end
 
-
     context 'with multi-level supply chain' do
       # Create a graph:
       # [Coal Producer] -> [Coal Plant] -> [Electricity Grid] -> [Data Center] -> [Terminus]
@@ -322,7 +321,6 @@
       end
     end
 
-
     context 'with zero total input' do
       let(:builder) do
         TestGraphBuilder.new.tap do |builder|
@@ -359,7 +357,8 @@
           builder.add(:green_gas_producer, groups: [:primary_energy_demand], demand: 30)
 
           # Network gas distributor receives from two sources
-          builder.connect(:natural_gas_producer, :network_gas_distributor, :natural_gas, type: :share)
+          builder.connect(:natural_gas_producer, :network_gas_distributor, :natural_gas,
+            type: :share)
           builder.connect(:green_gas_producer, :network_gas_distributor, :green_gas, type: :share)
 
           # Distributor supplies burner with mixed network gas (nil co2 value - uses recursion)

spec/serializers/emissions_export_serializer_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe EmissionsExportSerializer do
   let(:scenario) { Scenario.default }
-  let(:serializer) { EmissionsExportSerializer.new(scenario) }
+  let(:serializer) { described_class.new(scenario) }
 
   describe '#as_csv' do
     it 'returns a CSV string' do
@@ -30,14 +30,12 @@
       expect(csv.length).to be >= 1
 
       # If there are data rows, validate structure
-      if csv.length > 1
-        expect(csv[1].length).to eq(7)
-      end
+      expect(csv[1].length).to eq(7) if csv.length > 1
     end
 
     it 'formats node data correctly when rows exist' do
       csv = CSV.parse(serializer.as_csv)
-      data_rows = csv[1..-1]  # Skip header
+      data_rows = csv[1..] # Skip header
 
       # Each row (if any) should have 7 columns
       data_rows.each do |row|
@@ -49,21 +47,19 @@
       it 'exports CO2 capture as negative value' do
         csv = CSV.parse(serializer.as_csv)
         # Find any row with capture value
-        rows_with_capture = csv[1..-1].select { |row| row[2].to_f < 0 }
+        rows_with_capture = csv[1..].select { |row| row[2].to_f < 0 }
 
         # If there are CCS nodes, they should have negative capture
-        if rows_with_capture.any?
-          expect(rows_with_capture.first[2].to_f).to be < 0
-        end
+        expect(rows_with_capture.first[2].to_f).to be < 0 if rows_with_capture.any?
       end
 
       it 'validates Total GHG = Production - Capture + Other GHG' do
         csv = CSV.parse(serializer.as_csv)
-        data_rows = csv[1..-1]
+        data_rows = csv[1..]
 
         data_rows.each do |row|
           production = row[1].to_f
-          capture = row[2].to_f  # Already negative in export
+          capture = row[2].to_f # Already negative in export
           other_ghg = row[3].to_f
           total_ghg = row[4].to_f
 
@@ -111,7 +107,6 @@
       expect(serializer.send(:format_value, 1.23456789)).to eq('1.23456789')
     end
 
-
     it 'handles integer-like floats correctly' do
       expect(serializer.send(:format_value, 5.0)).to eq('5.0')
     end
@@ -126,33 +121,29 @@
     end
   end
 
-  describe '#has_emissions?' do
+  describe '#emissions?' do
     let(:node_with_fossil) do
       double('Node', query: double('Query',
         direct_co2_emission_of_fossil_gross: 10.0,
-        direct_co2_emission_of_bio_gross: 0.0
-      ))
+        direct_co2_emission_of_bio_gross: 0.0))
     end
 
     let(:node_with_bio) do
       double('Node', query: double('Query',
         direct_co2_emission_of_fossil_gross: 0.0,
-        direct_co2_emission_of_bio_gross: 5.0
-      ))
+        direct_co2_emission_of_bio_gross: 5.0))
     end
 
     let(:node_with_both) do
       double('Node', query: double('Query',
         direct_co2_emission_of_fossil_gross: 10.0,
-        direct_co2_emission_of_bio_gross: 5.0
-      ))
+        direct_co2_emission_of_bio_gross: 5.0))
     end
 
     let(:node_with_neither) do
       double('Node', query: double('Query',
         direct_co2_emission_of_fossil_gross: 0.0,
-        direct_co2_emission_of_bio_gross: 0.0
-      ))
+        direct_co2_emission_of_bio_gross: 0.0))
     end
 
     let(:node_with_error) do
@@ -162,23 +153,23 @@
     end
 
     it 'returns true for nodes with fossil emissions' do
-      expect(serializer.send(:has_emissions?, node_with_fossil)).to be true
+      expect(serializer.send(:emissions?, node_with_fossil)).to be(true)
     end
 
     it 'returns true for nodes with bio emissions' do
-      expect(serializer.send(:has_emissions?, node_with_bio)).to be true
+      expect(serializer.send(:emissions?, node_with_bio)).to be(true)
     end
 
     it 'returns true for nodes with both emission types' do
-      expect(serializer.send(:has_emissions?, node_with_both)).to be true
+      expect(serializer.send(:emissions?, node_with_both)).to be(true)
     end
 
     it 'returns false for nodes with no emissions' do
-      expect(serializer.send(:has_emissions?, node_with_neither)).to be false
+      expect(serializer.send(:emissions?, node_with_neither)).to be(false)
     end
 
     it 'returns false when query raises an error' do
-      expect(serializer.send(:has_emissions?, node_with_error)).to be false
+      expect(serializer.send(:emissions?, node_with_error)).to be(false)
     end
   end
 
@@ -198,11 +189,13 @@
     end
 
     let(:node_returning_nan) do
-      double('Node', key: :nan_node, query: double('Query', direct_co2_emission_of_fossil: Float::NAN))
+      double('Node', key: :nan_node,
+        query: double('Query', direct_co2_emission_of_fossil: Float::NAN))
     end
 
     let(:node_returning_infinity) do
-      double('Node', key: :inf_node, query: double('Query', direct_co2_emission_of_fossil: Float::INFINITY))
+      double('Node', key: :inf_node,
+        query: double('Query', direct_co2_emission_of_fossil: Float::INFINITY))
     end
 
     it 'returns the query result when successful' do
@@ -218,15 +211,17 @@
     end
 
     it 'returns nil when query returns NaN' do
-      expect(serializer.send(:safe_query, node_returning_nan, :direct_co2_emission_of_fossil)).to be_nil
+      expect(serializer.send(:safe_query, node_returning_nan,
+        :direct_co2_emission_of_fossil)).to be_nil
     end
 
     it 'returns nil when query returns Infinity' do
       expect(serializer.send(:safe_query, node_returning_infinity, :direct_co2_emission_of_fossil)).to be_nil
     end
 
     it 'returns nil when query returns nil' do
-      nil_node = double('Node', key: :nil_node, query: double('Query', direct_co2_emission_of_fossil: nil))
+      nil_node = double('Node', key: :nil_node,
+        query: double('Query', direct_co2_emission_of_fossil: nil))
       expect(serializer.send(:safe_query, nil_node, :direct_co2_emission_of_fossil)).to be_nil
     end
   end