Return full OUTPUT row for composite primary key inserts#1389
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
Copilot
AI
changed the title
Fix composite primary key assignment on create
Return full OUTPUT row for composite primary key inserts
Jun 7, 2026
Copilot created this pull request from a session on behalf of
aidanharan
June 7, 2026 11:51
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL Server inserts with composite primary keys were not assigning all database-generated key parts back to the created Active Record instance. In practice, only part of the returned key data was applied, leaving generated components (e.g.,
uniqueidentifier) unset on the in-memory record.Adapter behavior change
returning_column_valuesto return the full first returned row, not a single scalar.OUTPUT INSERTED...payloads used for composite keys.Regression coverage
(id IDENTITY, guid DEFAULT NEWID()).create!assigns both generated PK components (idandguid) to the created instance.