From 5099c58b82a538cfc943f479833d825c144984d5 Mon Sep 17 00:00:00 2001 From: justanotheranonymoususer Date: Fri, 26 Dec 2025 16:07:41 +0200 Subject: [PATCH 1/3] Don't open select on browser hotkeys --- src/SelectInput/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SelectInput/index.tsx b/src/SelectInput/index.tsx index 79980956..9f45b38c 100644 --- a/src/SelectInput/index.tsx +++ b/src/SelectInput/index.tsx @@ -147,7 +147,7 @@ export default React.forwardRef(function Selec } // Open dropdown when a valid open key is pressed - if (isValidateOpenKey(which)) { + if (!event.ctrlKey && !event.altKey && !event.metaKey && isValidateOpenKey(which)) { toggleOpen(true); } }, From 84596b0a0c956eeb987c46f33481010d23ad101b Mon Sep 17 00:00:00 2001 From: justanotheranonymoususer Date: Fri, 26 Dec 2025 16:11:01 +0200 Subject: [PATCH 2/3] Update index.tsx --- src/SelectInput/index.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/SelectInput/index.tsx b/src/SelectInput/index.tsx index 9f45b38c..a34a260b 100644 --- a/src/SelectInput/index.tsx +++ b/src/SelectInput/index.tsx @@ -147,7 +147,8 @@ export default React.forwardRef(function Selec } // Open dropdown when a valid open key is pressed - if (!event.ctrlKey && !event.altKey && !event.metaKey && isValidateOpenKey(which)) { + const isModifier = event.ctrlKey || event.altKey || event.metaKey; + if (!isModifier && isValidateOpenKey(which)) { toggleOpen(true); } }, From 05366986052bff4fdebe4ef1150667bbf771f3c8 Mon Sep 17 00:00:00 2001 From: justanotheranonymoususer Date: Fri, 26 Dec 2025 16:28:43 +0200 Subject: [PATCH 3/3] Test --- tests/Select.test.tsx | 30 ++++++++++++++++++++++++++++++ tests/utils/common.ts | 8 ++++++-- 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/tests/Select.test.tsx b/tests/Select.test.tsx index 34afca48..ebd495c5 100644 --- a/tests/Select.test.tsx +++ b/tests/Select.test.tsx @@ -1008,6 +1008,36 @@ describe('Select.Basic', () => { expectOpen(container, true); }); + it('not open on browser hotkeys with modifier keys', () => { + const { container } = render( + , + ); + + const inputEle = container.querySelector('input'); + + // Ctrl+key combinations (e.g., Ctrl+F for find, Ctrl+S for save) + keyDown(inputEle, KeyCode.F, { ctrlKey: true }); + expectOpen(container, false); + + keyDown(inputEle, KeyCode.S, { ctrlKey: true }); + expectOpen(container, false); + + // Alt+key combinations + keyDown(inputEle, KeyCode.F, { altKey: true }); + expectOpen(container, false); + + // Meta+key combinations (e.g., Cmd+key on Mac) + keyDown(inputEle, KeyCode.F, { metaKey: true }); + expectOpen(container, false); + + // Regular key without modifiers should still open + keyDown(inputEle, KeyCode.NUM_ONE); + expectOpen(container, true); + }); + it('close after select', () => { const { container } = render(