Merge branch 'main' into improve-lineheight-calc-ios

Author: ArekChr

.eslintrc.js

@@ -75,6 +75,7 @@ module.exports = {
         'lint/no-react-native-imports': 2,
         'lint/require-extends-error': 2,
         'lint/no-react-node-imports': 2,
+        'lint/no-react-default-imports': 2,
       },
     },
     {

.github/actions/build-hermesc-linux/action.yml

@@ -14,8 +14,12 @@ runs:
       shell: bash
       run: |
         sudo apt update
-        sudo apt install -y git openssh-client cmake build-essential \
+        sudo apt install -y git openssh-client build-essential \
             libreadline-dev libicu-dev jq zip python3
+
+        # Install cmake 3.28.3-1build7
+        sudo apt-get install cmake=3.28.3-1build7
+        sudo ln -sf /usr/bin/cmake /usr/local/bin/cmake
     - name: Restore Hermes workspace
       uses: ./.github/actions/restore-hermes-workspace
     - name: Linux cache

.github/actions/build-hermesc-windows/action.yml

@@ -39,6 +39,9 @@ runs:
         New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\icu
         New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\deps
         New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\win64-bin
+    - name: Downgrade CMake
+      shell: powershell
+      run: choco install cmake --version 3.31.6 --force
     - name: Build HermesC for Windows
       shell: powershell
       run: |

.github/actions/lint/action.yml

@@ -44,3 +44,6 @@ runs:
     - name: Check formatting
       shell: bash
       run: yarn run format-check
+    - name: Lint markdown
+      shell: bash
+      run: yarn run lint-markdown

.github/actions/yarn-install/action.yml

@@ -9,7 +9,7 @@ runs:
         ATTEMPT=0
         WAIT_TIME=20
         while [ $ATTEMPT -lt $MAX_ATTEMPTS ]; do
-            yarn install --non-interactive --frozen-lockfile && break
+            yarn install --non-interactive --frozen-lockfile --ignore-engines && break
             echo "yarn install failed. Retrying in $WAIT_TIME seconds..."
             sleep $WAIT_TIME
             ATTEMPT=$((ATTEMPT + 1))

.github/workflow-scripts/__tests__/extractIssueOncalls-test.js

@@ -0,0 +1,83 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+const {extractIssueOncalls} = require('../extractIssueOncalls');
+
+const userMap = {
+  '@g': '1785',
+  '@c': '1781',
+  '@s': '1272',
+  '@d': '1332',
+  '@m': '9555',
+  '@p': '6097',
+  '@f': '7565',
+};
+
+const schedule = {
+  '2025-04-01': ['@m', '@f'],
+  '2025-04-08': ['@g', '@d'],
+};
+
+describe('extractIssueOncalls', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    jest.useFakeTimers('modern');
+  });
+
+  afterEach(() => {
+    jest.useRealTimers();
+  });
+  it('extracts m and f on 6 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 6));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@m'], userMap['@f']]);
+  });
+
+  it('extracts m and f on 7 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 7));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@m'], userMap['@f']]);
+  });
+
+  it('extracts g and d on 8 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 8));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@g'], userMap['@d']]);
+  });
+
+  it('extracts g and d on 9 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 9));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@g'], userMap['@d']]);
+  });
+
+  it('extracts g and d on 10 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 10));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@g'], userMap['@d']]);
+  });
+
+  it('extracts g and d on 11 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 11));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@g'], userMap['@d']]);
+  });
+
+  it('extracts g and d on 12 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 12));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@g'], userMap['@d']]);
+  });
+
+  it('extracts g and d on 13 of April', () => {
+    jest.setSystemTime(new Date(2025, 3, 13));
+    const oncalls = extractIssueOncalls(schedule, userMap);
+    expect(oncalls).toEqual([userMap['@g'], userMap['@d']]);
+  });
+});

.github/workflow-scripts/collectNightlyOutcomes.js

@@ -0,0 +1,74 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+const fs = require('fs');
+const path = require('path');
+
+function readOutcomes() {
+  const baseDir = '/tmp';
+  let outcomes = {};
+  fs.readdirSync(baseDir).forEach(file => {
+    const fullPath = path.join(baseDir, file);
+    if (fullPath.endsWith('outcome') && fs.statSync(fullPath).isDirectory) {
+      fs.readdirSync(fullPath).forEach(subFile => {
+        const subFullPath = path.join(fullPath, subFile);
+        if (subFullPath.endsWith('outcome')) {
+          const [library, status] = String(fs.readFileSync(subFullPath, 'utf8'))
+            .trim()
+            .split(':');
+          const platform = subFile.includes('android') ? 'Android' : 'iOS';
+          console.log(
+            `[${platform}] ${library} completed with status ${status}`,
+          );
+          outcomes[library.trim()] = {
+            platform,
+            status: status.trim(),
+          };
+        }
+      });
+    } else if (fullPath.endsWith('outcome')) {
+      const [library, status] = String(fs.readFileSync(fullPath, 'utf8'))
+        .trim()
+        .split(':');
+      const platform = file.includes('android') ? 'Android' : 'iOS';
+      console.log(`[${platform}] ${library} completed with status ${status}`);
+      outcomes[library.trim()] = {
+        platform,
+        status: status.trim(),
+      };
+    }
+  });
+  return outcomes;
+}
+
+function printFailures(outcomes) {
+  console.log('Printing failures...');
+  let failures = 0;
+  Object.entries(outcomes).forEach(([library, value]) => {
+    if (value.status !== 'success') {
+      console.log(
+        `❌ [${value.platform}] ${library} failed with status ${value.status}`,
+      );
+      failures++;
+    }
+  });
+  return failures > 0;
+}
+
+function collectResults() {
+  const outcomes = readOutcomes();
+  const failures = printFailures(outcomes);
+  if (failures) {
+    process.exit(1);
+  }
+  console.log('✅ All tests passed!');
+}
+module.exports = {
+  collectResults,
+};

.github/workflow-scripts/extractIssueOncalls.js

@@ -0,0 +1,61 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+const fs = require('fs');
+
+const MSEC_IN_DAY = 1000 * 60 * 60 * 24;
+
+function formatUsers(users) {
+  console.log(`${users[0]} ${users[1]}`.trim());
+}
+
+function extractUsersFromScheduleAndDate(schedule, userMap, date) {
+  const year = date.getFullYear();
+  const month = date.getMonth() + 1; // 0 is January, 1 is February
+  const day = date.getDate();
+  const dateStr = `${year}-${month < 10 ? `0${month}` : month}-${day < 10 ? `0${day}` : day}`;
+  const user1 = userMap[schedule[dateStr][0]];
+  const user2 = userMap[schedule[dateStr][1]];
+  return [user1, user2];
+}
+
+function main() {
+  const configuration = process.argv[2];
+  const {userMap, schedule} = JSON.parse(configuration);
+  extractIssueOncalls(schedule, userMap);
+}
+
+function extractIssueOncalls(schedule, userMap) {
+  const now = new Date();
+  const dayOfTheWeek = now.getDay(); // 0 is Sunday, 1 is Monday, etc.
+  let users;
+  if (dayOfTheWeek === 2) {
+    // exact match in the schedule
+    users = extractUsersFromScheduleAndDate(schedule, userMap, now);
+  } else if (dayOfTheWeek < 2) {
+    // sunday
+    // go to the tuesday of the last week
+    const lastWeekTuesday = new Date(now - (5 + dayOfTheWeek) * MSEC_IN_DAY);
+    users = extractUsersFromScheduleAndDate(schedule, userMap, lastWeekTuesday);
+  } else if (dayOfTheWeek > 1) {
+    // go to the previous tuesday
+    const thisWeekTuesday = new Date(now - (dayOfTheWeek - 2) * MSEC_IN_DAY);
+    users = extractUsersFromScheduleAndDate(schedule, userMap, thisWeekTuesday);
+  }
+  formatUsers(users);
+  return users;
+}
+
+if (require.main === module) {
+  void main();
+}
+
+module.exports = {
+  extractIssueOncalls,
+};

.github/workflow-scripts/publishTemplate.js

@@ -69,6 +69,9 @@ module.exports.verifyPublishedTemplate = async (
   retries = MAX_RETRIES,
 ) => {
   try {
+    if (version.startsWith('v')) {
+      version = version.slice(1);
+    }
     await verifyPublishedPackage(
       TEMPLATE_NPM_PKG,
       version,

.github/workflows/monitor-new-issues.yml

@@ -5,14 +5,33 @@ on:
     - cron: "0 0,6,12,18 * * *"
   workflow_dispatch:
 
+# Reminder for when we have to update the schedule (before Jan 2026):
+# the secrets.ONCALL_SCHEDULE secret must be on a single line and must have all the `"` escaped as `\"`.
+# Only a meta engineer can update it through the OSS internal portal.
+
 jobs:
   monitor-issues:
     runs-on: ubuntu-latest
     steps:
+      - name: Checkout
+        uses: actions/checkout@v4
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
           node-version: '20'
+      - name: Install dependencies
+        uses:  ./.github/actions/yarn-install
+      - name: Extract next oncall
+        run: |
+          ONCALLS=$(node ./.github/workflow-scripts/extractIssueOncalls.js "${{ secrets.ONCALL_SCHEDULE }}")
+          ONCALL1=$(echo $ONCALLS | cut -d ' ' -f 1)
+          ONCALL2=$(echo $ONCALLS | cut -d ' ' -f 2)
+          echo "oncall1=$ONCALL1" >> $GITHUB_ENV
+          echo "oncall2=$ONCALL2" >> $GITHUB_ENV
+      - name: Print oncalls
+        run: |
+          echo "oncall1: ${{ env.oncall1 }}"
+          echo "oncall2: ${{ env.oncall2 }}"
       - name: Monitor New Issues
         uses: react-native-community/repo-monitor@v1.0.1
         with:
@@ -23,5 +42,5 @@ jobs:
           repo_owner: "facebook"
           repo_name: "react-native"
           discord_webhook_url: "${{ secrets.DISCORD_WEBHOOK_URL }}"
-          discord_id_type: "role"
-          discord_ids: "1339243367841927228"
+          discord_id_type: "user"
+          discord_ids: "${{ env.oncall1 }},${{ env.oncall2 }}"