Trimming of exclamation mark

[thomas-zahner]

Running

    #[test]
    fn test_1872() {
        use linkify::LinkFinder;
        let links: Vec<&str> = LinkFinder::new()
            .links("https://lychee.cli.rs/!/ and https://lychee.cli.rs/test!/")
            .map(|l| l.as_str())
            .collect();

        assert_eq!(
            vec!["https://lychee.cli.rs/!/", "https://lychee.cli.rs/test!/"],
            links
        );
    }

fails with

assertion `left == right` failed
  left: ["https://lychee.cli.rs/!/", "https://lychee.cli.rs/test!/"]
 right: ["https://lychee.cli.rs/", "https://lychee.cli.rs/test"]

Is this expected behaviour?
Or could we update linkify to make this test pass, as these are valid URLs?

[thomas-zahner]

As a data point, GitHub's markdown parser consider this exclamation mark as part of the URL: https://lychee.cli.rs/!/
… but not this one: https://lychee.cli.rs/!
And you can use angle brackets for disambiguation, e.g.: <https://lychee.cli.rs/!> → https://lychee.cli.rs/!
For lychee, adding angle brackets doesn't help. ☹

Originally posted by @jwilk in #1872

So it would probably make sense to treat ! as part of the URL, as long as it is followed by /. Otherwise, we can keep the behaviour of considering trailing exclamation marks as part of the text instead of the URL.

[robinst]

So it would probably make sense to treat ! as part of the URL, as long as it is followed by /. Otherwise, we can keep the behaviour of considering trailing exclamation marks as part of the text instead of the URL.

Agreed. Happy to accept a PR for changing this.

[robinst]

Released in version 0.11.0 now, thanks @mre for the fix! https://github.com/robinst/linkify/blob/main/CHANGELOG.md#0110---2026-04-12

[mre]

Oh! So nice. Thanks for the quick turnaround. 😃