Skip to content

docs: clarify Bash-only auto-rewrite scope#413

Open
tsubasakong wants to merge 1 commit intortk-ai:developfrom
tsubasakong:lucas/docs-387-tool-rewrite-clarify
Open

docs: clarify Bash-only auto-rewrite scope#413
tsubasakong wants to merge 1 commit intortk-ai:developfrom
tsubasakong:lucas/docs-387-tool-rewrite-clarify

Conversation

@tsubasakong
Copy link

@tsubasakong tsubasakong commented Mar 8, 2026

Summary

  • clarify that the auto-rewrite hook only runs on Bash tool calls
  • note that Claude Code built-in Read, Grep, and Glob tools are not auto-rewritten
  • point readers to shell commands or explicit rtk read / rtk grep / rtk find when they want RTK filtering

Fixes #387.

Validation

  • docs-only change
  • verified the updated guidance appears in the Quick Start and Auto-Rewrite Hook sections of README.md

@aeppling
Copy link
Contributor

aeppling commented Mar 8, 2026

Hello, this should target develop branch, please read CONTRIBUTING.md

@aeppling
Copy link
Contributor

aeppling commented Mar 9, 2026

image

You're still targeting master branch, please recreate this PR to develop branch so we validate

@pszymkowiak
Copy link
Collaborator

Thanks for the clarification — the content about Bash-only hook scope is useful.

However this PR has conflicts and the version bumps are outdated (we're on 0.28.1 now). Please:

  1. Rebase on master:

    git fetch upstream master
    git rebase upstream/master
  2. Drop the version bump changes — only keep the Bash-only scope clarifications in README.md. Don't modify CLAUDE.md or ARCHITECTURE.md (version numbers are managed by release-please).

  3. Add DCO sign-off:

    git commit --amend -s --no-edit
    git push --force-with-lease

Signed-off-by: Frank <97429702+tsubasakong@users.noreply.github.com>
@tsubasakong tsubasakong force-pushed the lucas/docs-387-tool-rewrite-clarify branch from 35889cb to 992f2ce Compare March 12, 2026 03:53
@tsubasakong tsubasakong changed the base branch from master to develop March 12, 2026 03:53
@tsubasakong
Copy link
Author

Retargeted to develop, dropped the unrelated version bump edits, and reduced this back to the README-only clarification requested in review. The branch was also rebuilt as a fresh signed-off commit on top of current develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic Claude Issues / Grep, Read, Glob not being rewritten as they're not Bash commands

3 participants