Skip to content

Commit 29bb06d

Browse files
committed
Exclude linker errors from compile test failure check
The MinGW linker hits the 65535 export ordinal limit when linking all test bindings into one DLL. Filter out linker errors since the compile test only validates that generated C++ code compiles cleanly.
1 parent 4c8315b commit 29bb06d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/compile_rice_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def test_compile_bindings
2525
output, success = run_cmake("--build", "build/#{preset}")
2626
unless success
2727
# Link errors are expected (no implementations). Only fail on compile errors.
28-
compile_errors = output.lines.select { |line| line =~ / error:/ || line =~ /error C\d{4}/ }
28+
compile_errors = output.lines.select { |line| (line =~ / error:/ || line =~ /error C\d{4}/) && line !~ /ld\.exe|collect2|link\.exe|export ordinal/ }
2929
flunk "Compile errors:\n#{compile_errors.join}" unless compile_errors.empty?
3030
end
3131
end

0 commit comments

Comments
 (0)