-
Notifications
You must be signed in to change notification settings - Fork 74
Add new targets for Cygwin (and MSYS2) #826
Copy link
Copy link
Closed
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Metadata
Metadata
Assignees
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Type
Fields
Give feedbackNo fields configured for issues without a type.
Proposal
Cygwin is a POSIX-compatible layer on Windows. MSYS2 is a fork of Cygwin. I want to add new targets for Cygwin. The main motivation is to compile fish-shell to Windows.
My proposed targets are
x86_64-pc-cygwinandx86_64-pc-cygwin-msys2. The PR is here: rust-lang/rust#134999 . They are tier 3 targets, but we faced some problems: should this target inwindowsfamily or inunixfamily? I would suggestunixfamily, because Cygwin is such an layer to provide POSIX apis and make porting unix programs easy.Mentors or Reviewers
@jieyouxu suggested me to open this issue.
Process
The main points of the Major Change Process are as follows:
@rustbot second.-C flag, then full team check-off is required.@rfcbot fcp mergeon either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
I have succeeded building my own rustc targeting cygwin and compiled fish on Windows.