-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
compiletest "not found errors" output is badly formatted #140940
Copy link
Copy link
Closed
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
When compiletest encounters "not found errors", its output now looks like this:
That looks glitched out, with the lack of a space before "line". I think the line number should probably come first anyway, before the diagnostic kind.
I think this is a regression, this used to look just fine.
The formatting seems to happen here:
rust/src/tools/compiletest/src/errors.rs
Line 80 in 56d6b4e
Cc @petrochenkov