-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Globs in save-analysis do not contain exports in value #49910
Copy link
Copy link
Closed as not planned
Labels
A-save-analysisArea: saving results of analyses such as inference and borrowck results to a file.Area: saving results of analyses such as inference and borrowck results to a file.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-langRelevant to the language teamRelevant to the language team
Metadata
Metadata
Assignees
Labels
A-save-analysisArea: saving results of analyses such as inference and borrowck results to a file.Area: saving results of analyses such as inference and borrowck results to a file.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-langRelevant to the language teamRelevant to the language team
Type
Fields
Give feedbackNo fields configured for issues without a type.
Uncovered by rust-dev-tools/rls-analysis#124.
For the following code:
The save analysis data for the glob use has an empty string for the
value, when I would expectStruct1andStruct2would be in the string.The theory is that the
glob_mapcreated by thelibrustc_resolve::Resolveronly contains imports actually used inside the module, but the save analysis data wants to include exports as well. The glob_map is used to create thevaluefield in the analysis here.I'm happy to work and submit a PR for this, but I don't think that I understand enough about the resolve code to move forward, particularly around what causes an import to be considered "used". Could someone give me some help?