-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Adding a doc comment talking about performance impacts of assume #77561
Copy link
Copy link
Closed
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-intrinsicsArea: IntrinsicsArea: IntrinsicsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-intrinsicsArea: IntrinsicsArea: IntrinsicsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
So LLVM hasn't changed much since nagisa wrote #54995 (comment).
Here the link to related regression caused by using constly assume intrinsic in const fn: #77023 (comment)
I think we could include a warning for assume intrinsic about using it in const fn and should run a perf for PR using it.
rust/library/core/src/intrinsics.rs
Lines 735 to 737 in ced813f
cc @oli-obk