Implement display for Text

[janTatesa]

It already implements to_string so why not

[adamreichold]

Text does not directly implement ToString, it implements Deref<Target=str> which implies access to .to_string() via automatic dereferencing.

Do you need a direct implementation of Display or could you just as well pass &*text or text.deref() to get a &str and use that intead?

[janTatesa]

A direct implementation would be more ergonomic as it can be directly used in format! strings instead of making them an argument and doing as_str on them

[adamreichold]

I think that making rarely necessary code (directly formatting Text instances) easier to write against the ongoing maintenance cost of adding forwarding trait impls for Text is a questionable trade-off. For example, which other traits should we implement?

Personally, I rather wonder if should the Text layer outright and just use StrTendril directly. This possibly applies to Comment as well though it at least adds a non-trivial Debug impl.

[janTatesa]

I don't see a maintenance cost. Just write those forwarding traits once and forget about them

[adamreichold]

and forget about them

Not doing that is exactly what is called "maintenance".

[janTatesa]

What maintenance would those methods require? This reminds me of https://xkcd.com/3109/

[adamreichold]

Adding a trait impl on a public type is a semver hazard and has coherence implications. It generally adds complexity and opens up a whole set of design questions relevant to the overall consistency of the library, e.g. which other traits or for which similar types.

To be frank, I understand that having your concern rejected can be frustrating. But "maintenance" also means saying "no" more often than saying "yes" and I urge you to discuss this in good faith instead of snarky one liners.