Use ClassVar for Packet.fields_desc type hint#4998
Open
T3pp31 wants to merge 1 commit into
Open
Conversation
AI-Assisted: yes (Codex)
c732048 to
505acab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4998 +/- ##
==========================================
- Coverage 80.31% 80.29% -0.03%
==========================================
Files 381 383 +2
Lines 93630 95159 +1529
==========================================
+ Hits 75202 76405 +1203
- Misses 18428 18754 +326
🚀 New features to boost your workflow:
|
Contributor
Author
|
CI note: after adding the required The remaining failing check is Relevant checks for this change are passing, including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClassVarinscapy.packetPacket.fields_descasClassVar[List[AnyField]]Closes #4991
Checks
python3 -m py_compile scapy/packet.pygit diff --checkNot run locally:
tox -e flake8(toxresolves to a broken pyenv-win shim;python3 -m toxis not installed)tox -e mypy(same tox issue)python3 -m ruff check --select RUF012 scapy/packet.py(ruffis not installed)