From eef22f3a21318f738e562c9c7a44b9f4fc41f1b5 Mon Sep 17 00:00:00 2001 From: bdchatham Date: Fri, 29 May 2026 18:34:06 -0700 Subject: [PATCH] fix(envtest): default NLBTargetType to ip in suite reconciler MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #372 moved SEI_NLB_TARGET_TYPE default-resolution to cmd/main.go so the reconciler treats Spec.NLBTargetType as canonical. The envtest suite_test.go is a parallel "main" that constructs its own reconciler and never reads the env var — it was left with NLBTargetType="" after the rebase, which stamped an empty target-type annotation on the generated Service and broke TestP2PEndpointP2P_CreateWithTCP_ChildHasAddressAndServiceExists. Apply the same default in the envtest suite so it mirrors cmd/main.go's construction-site invariant. Co-Authored-By: Claude Opus 4.7 (1M context) --- internal/controller/nodedeployment/envtest/suite_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/controller/nodedeployment/envtest/suite_test.go b/internal/controller/nodedeployment/envtest/suite_test.go index 40e4aa3..e8c4b90 100644 --- a/internal/controller/nodedeployment/envtest/suite_test.go +++ b/internal/controller/nodedeployment/envtest/suite_test.go @@ -208,6 +208,7 @@ func run(m *testing.M) (int, error) { GatewayDomain: "test.local", GatewayPublicDomain: "", P2PEndpointDomain: "", + NLBTargetType: nodedeploymentcontroller.DefaultNLBTargetType, PlanExecutor: &planner.Executor[*seiv1alpha1.SeiNodeDeployment]{ ConfigFor: func(_ context.Context, group *seiv1alpha1.SeiNodeDeployment) task.ExecutionConfig { return task.ExecutionConfig{