Skip to content

Commit f084346

Browse files
committed
docs: update and cleanup some info
1 parent 19820c3 commit f084346

File tree

3 files changed

+22
-26
lines changed

3 files changed

+22
-26
lines changed

CONTRIBUTING.md

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,26 @@ Do you want to help out but don't know where to start?
55
## Guideline Contents
66

77
There are a lot of ways to get involved and help out:
8-
- [Reporting an issue](#reporting-issues)
9-
- [Requesting features](#requesting-features)
10-
- [Submitting Pullrequests](#pullrequests)
11-
- [Writing tests](#writing-tests)
12-
- [Writing Documentation](#writing-docs)
13-
- [Sample Projects](#sample-projects)
148

15-
<a name="reporting-issues"></a>
16-
## Reporting An Issue
9+
- [Contribute to SerialPort!](#contribute-to-serialport)
10+
- [Guideline Contents](#guideline-contents)
11+
- [Reporting an Issue](#reporting-an-issue)
12+
- [Requesting Features](#requesting-features)
13+
- [What feature you'd like to see](#what-feature-youd-like-to-see)
14+
- [Why this is important to you](#why-this-is-important-to-you)
15+
- [Submitting Pull Requests](#submitting-pull-requests)
16+
- [Writing Tests](#writing-tests)
17+
- [Writing Documentation](#writing-documentation)
18+
- [Sample Projects](#sample-projects)
1719

18-
SerialPort does it's [issue tracking](https://github.com/serialport/node-serialport/issues) through github. To report an issue first search the repo to make sure that it has not been reported before. If no one has reported the bug before, create a new issue and be sure to follow the issue template.
20+
## Reporting an Issue
21+
22+
SerialPort does it's [issue tracking](https://github.com/serialport/node-serialport/issues) through github. To report an issue first search the repo to make sure that it has not been reported before. If no one has reported the bug before, create a new issue and be sure to follow the issue template.
1923

2024
If the issue has been reported before but you have new information to help troubleshoot the issue, add a comment to the thread with the same information as requested above.
2125

22-
<a name="requesting-features"></a>
2326
## Requesting Features
27+
2428
To request a new feature be added take a look at the [current roadmap](https://github.com/serialport/node-serialport/milestones) and create a [github issue](https://github.com/serialport/node-serialport/issues) and include:
2529

2630
### What feature you'd like to see
@@ -29,9 +33,9 @@ To request a new feature be added take a look at the [current roadmap](https://g
2933

3034
This is here because it's interesting knowing what cool things people are working on and also could help community members make suggestions for work-arounds until the feature is built.
3135

32-
<a name="pullrequests"></a>
3336
## Submitting Pull Requests
34-
To contribute code to SerialPort, fork the project onto your github account and do your work in a branch. Before you submit the PR, make sure to rebase master into your branch so that you have the most recent changes and nothing breaks or conflicts. Lint and test your code using `npm run lint` and `npm run test`.
37+
38+
To contribute code to SerialPort, fork the project onto your github account and do your work in a branch. Before you submit the PR, make sure to rebase master into your branch so that you have the most recent changes and nothing breaks or conflicts. Lint and test your code using `npm run lint` and `npm run test`.
3539

3640
All contributions must adhere to the eslint rules by maintaining the existing coding style.
3741

@@ -41,19 +45,16 @@ When contributing new features you must include documentation.
4145

4246
It's very important that your pull requests include all of the above in order for users to be able to use your code. Pull requests with undocumented code will not be accepted.
4347

44-
<a name="writing-tests"></a>
4548
## Writing Tests
4649

47-
Tests are written using [mocha](https://mochajs.org/), [chai](http://chaijs.com/) and [sinon](http://sinonjs.org/). If you are having issues making a test pass, ask for help in the SerialPort [gitter](https://gitter.im/serialport/node-serialport) room or on your PR. Tests can be the hardest part to write when contributing code, so don't be discouraged.
50+
Tests are written using [mocha](https://mochajs.org/), [chai](http://chaijs.com/) and [sinon](http://sinonjs.org/). If you are having issues making a test pass, ask for help in the SerialPort [gitter](https://gitter.im/serialport/node-serialport) room or on your PR. Tests can be the hardest part to write when contributing code, so don't be discouraged.
4851

49-
<a name="writing-docs"></a>
5052
## Writing Documentation
5153

52-
We are always looking to improve our docs. If you find that any are lacking information or have wrong information, fix and submit a PR. If you're looking for areas to start writing docs for, see the [docs](https://github.com/serialport/node-serialport/labels/docs) label in issues.
54+
We are always looking to improve our docs. If you find that any are lacking information or have wrong information, fix and submit a PR. If you're looking for areas to start writing docs for, see the [docs](https://github.com/serialport/node-serialport/labels/docs) label in issues.
5355

5456
We use [Docusaurus](https://docusaurus.io/) to generate our docs. Make your changes to `/docs/` or in the `/packages/website/` folder in the [website repo](https://github.com/serialport/website)
5557

56-
<a name="sample-projects"></a>
5758
## Sample Projects
5859

5960
Have you made something cool with SerialPort? Is it part of your latest product? Let us know! There are a lot of people out there hacking on similar projects and looking for ideas, help or code. It's great to share!

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ SerialPort is currently employees a [governance](https://medium.com/the-node-js-
6363

6464
If you have a PR that improves the project people in any or all of the above people will help you land it.
6565

66-
**Maintainers**
66+
### Maintainers
6767

68-
- [Francis Gulotta](https://twitter.com/reconbot) | [reconbot](https://github.com/reconbot)
69-
- [Nick Hehr](https://twitter.com/hipsterbrown) | [hipsterbrown](https://github.com/hipsterbrown)
68+
- [Francis Gulotta](https://toot.cafe/@reconbot) | [reconbot](https://github.com/reconbot)
69+
- [Nick Hehr](https://toot.cafe/@hipsterbrown) | [hipsterbrown](https://github.com/hipsterbrown)
7070

7171
### Contributors
7272

SECURITY.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@
44

55
We currently support the latest version of serialport only.
66

7-
| Version | Supported |
8-
| ------- | ------------------ |
9-
| 9.x.x | :white_check_mark: |
10-
| < 9.0.x | :x: |
11-
127
## Reporting a Vulnerability
138

14-
Please email security@serialport.io if you find any issues and we'll talk about it. You can find a GPG key on keybase.
9+
Please email security@serialport.io if you find any issues and we'll talk about it.

0 commit comments

Comments
 (0)