fix(rename): make inline rename await mutateAsync so isSaving disables the field; recover edits on failure

- useInlineRename: catch onSave rejection — log, restore the original name,
  keep the edit session open, and re-arm doneRef (mirrors useItemRename)
- switch rename call sites (files, tables, table header, knowledge base,
  document) from mutate() to mutateAsync() so isSaving spans the request
- table-grid column rename stays fire-and-forget by design (optimistic local
  update + undo entry)

Author: emir-karabeg

apps/sim/app/workspace/[workspaceId]/files/files.tsx

@@ -274,23 +274,19 @@ export function Files() {
     onSave: (rowId, name) => {
       const parsed = parseRowId(rowId)
       if (parsed.kind === 'folder') {
-        updateFolder.mutate({ workspaceId, folderId: parsed.id, updates: { name } })
-        return
+        return updateFolder.mutateAsync({ workspaceId, folderId: parsed.id, updates: { name } })
       }
-      renameFile.mutate({ workspaceId, fileId: parsed.id, name })
+      return renameFile.mutateAsync({ workspaceId, fileId: parsed.id, name })
     },
   })
 
   const headerRename = useInlineRename({
-    onSave: (fileId, name) => {
-      renameFile.mutate({ workspaceId, fileId, name })
-    },
+    onSave: (fileId, name) => renameFile.mutateAsync({ workspaceId, fileId, name }),
   })
 
   const breadcrumbRename = useInlineRename({
-    onSave: (folderId, name) => {
-      updateFolder.mutate({ workspaceId, folderId, updates: { name } })
-    },
+    onSave: (folderId, name) =>
+      updateFolder.mutateAsync({ workspaceId, folderId, updates: { name } }),
   })
 
   const selectedFile = useMemo(

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

@@ -254,7 +254,7 @@ export function Document({
   const { mutate: updateChunkMutation } = useUpdateChunk()
   const { mutate: deleteDocumentMutation, isPending: isDeletingDocument } = useDeleteDocument()
   const { mutate: bulkChunkMutation, isPending: isBulkOperating } = useBulkChunkOperation()
-  const { mutate: updateDocumentMutation } = useUpdateDocument()
+  const { mutateAsync: updateDocumentMutation } = useUpdateDocument()
 
   const docRename = useInlineRename({
     onSave: (docId, filename) =>

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx

@@ -228,7 +228,7 @@ export function KnowledgeBase({
   const { mutate: deleteDocumentMutation } = useDeleteDocument()
   const { mutate: deleteKnowledgeBaseMutation, isPending: isDeleting } =
     useDeleteKnowledgeBase(workspaceId)
-  const { mutate: updateKnowledgeBaseMutation } = useUpdateKnowledgeBase(workspaceId)
+  const { mutateAsync: updateKnowledgeBaseMutation } = useUpdateKnowledgeBase(workspaceId)
 
   const kbRename = useInlineRename({
     onSave: (kbId, name) =>

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

@@ -343,7 +343,7 @@ export function Table({
     onSave: (_id, name) => {
       const data = tableDataRef.current
       if (data) pushTableRenameUndoSinkRef.current?.(data.name, name)
-      renameTableMutation.mutate({ tableId, name })
+      return renameTableMutation.mutateAsync({ tableId, name })
     },
   })
 

apps/sim/app/workspace/[workspaceId]/tables/tables.tsx

@@ -80,7 +80,7 @@ export function Tables() {
   const importCsvAsync = useImportCsvAsync()
 
   const tableRename = useInlineRename({
-    onSave: (tableId, name) => renameTable.mutate({ tableId, name }),
+    onSave: (tableId, name) => renameTable.mutateAsync({ tableId, name }),
   })
 
   const [isDeleteDialogOpen, setIsDeleteDialogOpen] = useState(false)

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/general/components/version-description-modal.tsx

@@ -2,15 +2,13 @@
 
 import { useRef, useState } from 'react'
 import {
-  Chip,
   ChipConfirmModal,
   ChipModal,
   ChipModalBody,
   ChipModalError,
   ChipModalField,
   ChipModalFooter,
   ChipModalHeader,
-  ChipTextarea,
 } from '@/components/emcn'
 import {
   useGenerateVersionDescription,
@@ -98,41 +96,33 @@ export function VersionDescriptionModal({
         <ChipModalHeader onClose={() => handleCloseAttempt()}>Version Description</ChipModalHeader>
         <ChipModalBody>
           <ChipModalField
-            type='custom'
+            type='textarea'
             title={
               <span>
                 {currentDescription ? 'Edit the' : 'Add a'} description for{' '}
                 <span className='font-medium text-[var(--text-primary)]'>{versionName}</span>
               </span>
             }
+            value={description}
+            onChange={setDescription}
+            placeholder='Describe the changes in this deployment version...'
+            maxLength={2000}
+            minHeight={120}
+            disabled={isGenerating}
             hint={`${description.length}/2000`}
-          >
-            <div className='flex justify-end'>
-              <Chip
-                flush
-                onClick={handleGenerateDescription}
-                disabled={isGenerating || updateMutation.isPending}
-              >
-                {isGenerating ? 'Generating...' : 'Generate'}
-              </Chip>
-            </div>
-            <ChipTextarea
-              value={description}
-              onChange={(event) => setDescription(event.target.value)}
-              placeholder='Describe the changes in this deployment version...'
-              maxLength={2000}
-              disabled={isGenerating}
-              className='min-h-[120px]'
-              aria-label='Version description'
-            />
-          </ChipModalField>
+          />
           <ChipModalError>
             {updateMutation.error?.message || generateMutation.error?.message}
           </ChipModalError>
         </ChipModalBody>
         <ChipModalFooter
           onCancel={handleCloseAttempt}
           cancelDisabled={updateMutation.isPending || isGenerating}
+          secondaryAction={{
+            label: isGenerating ? 'Generating...' : 'Generate',
+            onClick: handleGenerateDescription,
+            disabled: isGenerating || updateMutation.isPending,
+          }}
           primaryAction={{
             label: updateMutation.isPending ? 'Saving...' : 'Save',
             onClick: handleSave,

apps/sim/hooks/use-inline-rename.ts

@@ -1,7 +1,15 @@
 import { useCallback, useRef, useState } from 'react'
+import { createLogger } from '@sim/logger'
+
+const logger = createLogger('useInlineRename')
 
 interface UseInlineRenameProps {
-  onSave: (id: string, newName: string) => void | Promise<void>
+  /**
+   * Persists the new name. Return the mutation promise (e.g. React Query's
+   * `mutateAsync(...)`) — NOT a fire-and-forget `mutate(...)` — so `isSaving`
+   * spans the in-flight request and a rejection can revive the edit session.
+   */
+  onSave: (id: string, newName: string) => undefined | Promise<unknown>
 }
 
 /**
@@ -56,7 +64,6 @@ export function useInlineRename({ onSave }: UseInlineRenameProps) {
     setIsSaving(true)
     try {
       await onSaveRef.current(id, trimmed)
-    } finally {
       /**
        * Only clear editing state if this submit still owns the edit session.
        * Without the guard, a slow save for row A would tear down a rename of
@@ -65,9 +72,23 @@ export function useInlineRename({ onSave }: UseInlineRenameProps) {
        * new session, and the new session's own submit handles its lifecycle.
        */
       if (editingIdRef.current === id) {
-        setIsSaving(false)
         setEditingId(null)
       }
+    } catch (error) {
+      logger.error('Failed to rename item', { error, id, newName: trimmed })
+      /**
+       * Mirror `useItemRename`'s failure path: stay in edit mode with the
+       * original name restored (no silent data loss, no unhandled rejection)
+       * and re-arm `doneRef` so the revived session can submit or cancel again.
+       */
+      if (editingIdRef.current === id) {
+        setEditValue(originalNameRef.current)
+        doneRef.current = false
+      }
+    } finally {
+      if (editingIdRef.current === id) {
+        setIsSaving(false)
+      }
     }
   }, [])