fix(integrations): vanta review feedback - unique svg ids, mime type for base64 uploads, auth check consistency

waleedlatif1 · waleedlatif1 · commit 26ba1469309b · 2026-06-11T22:24:30.000-07:00
diff --git a/apps/docs/components/icons.tsx b/apps/docs/components/icons.tsx
@@ -7556,12 +7556,15 @@ export function OnePasswordIcon(props: SVGProps<SVGSVGElement>) {
 }
 
 export function VantaIcon(props: SVGProps<SVGSVGElement>) {
+  const id = useId()
+  const clipId = `vanta_clip_${id}`
+  const maskId = `vanta_mask_${id}`
   return (
     <svg {...props} viewBox='0 0 512 512' fill='none' xmlns='http://www.w3.org/2000/svg'>
-      <g clipPath='url(#vanta-icon-clip)'>
+      <g clipPath={`url(#${clipId})`}>
         <circle cx='256' cy='256' r='256' fill='#AC55FF' />
         <mask
-          id='vanta-icon-mask'
+          id={maskId}
           style={{ maskType: 'alpha' }}
           maskUnits='userSpaceOnUse'
           x='0'
@@ -7571,7 +7574,7 @@ export function VantaIcon(props: SVGProps<SVGSVGElement>) {
         >
           <circle cx='256' cy='256' r='256' fill='#AC55FF' />
         </mask>
-        <g mask='url(#vanta-icon-mask)'>
+        <g mask={`url(#${maskId})`}>
           <path
             d='M269.699 530.451C360.294 530.451 407.136 502.376 421.276 474.223C422.09 472.599 420.53 470.761 418.81 471.332C402.863 476.607 390.96 466.808 389.625 455.498C389.625 455.498 385.167 407.538 369.22 402.858C370.165 400.913 374.01 385.586 362.126 371.424C365.376 361.406 362.691 354.81 360.26 349.823C363.222 346.191 365.498 341.506 366.482 336.943C366.726 335.861 366.721 334.905 367.598 333.887C373.201 329.231 379.384 325.389 383.145 318.574C389.923 306.26 385.382 292.196 377.167 281.817C376.334 280.671 375.681 280.12 375.622 277.176C375.642 272.145 374.731 266.968 372.027 262.717C370.648 260.557 368.84 258.69 366.945 256.959C359.052 249.598 349.609 244.163 340.542 238.293C339.295 237.494 337.843 236.431 337.302 234.978C334.447 224.351 327.065 216.131 317.886 213.894C317.691 206.776 310.187 195.983 298.835 195.983C295.371 195.983 292.506 197.865 290.718 194.623C286.566 186.75 278.293 185.287 273.976 185.088C273.25 185.053 273.046 184.078 273.704 183.766C275.087 183.103 277.182 182.187 280.291 180.988C295.882 173.524 289.431 131.009 283.049 108.575C280.062 100.199 272.49 76.3803 253.942 74.8057C252.665 74.6985 251.359 74.7277 250.126 75.0836C246.555 76.1122 243.909 78.9738 242.048 82.9372C235.914 95.2709 234.379 128.562 232.123 142.797C228.922 163.096 226.023 184.873 215.913 193.799C211.606 182.436 205.374 177.171 201.969 177.37C199.001 178.068 203.016 183.835 201.306 192.341C200.117 197.236 197.408 201.804 192.794 201.804C179.273 201.804 167.098 134.173 163.463 93.5451C163.365 92.4824 163.263 91.4245 163.068 90.3715C161.285 80.5533 156.12 74.757 150.663 74.757C147.896 74.757 137.961 73.7478 126.584 91.639C118.764 105.591 113.795 120.177 113.312 147.341C113.322 174.714 125.532 193.019 130.477 202.023C150.688 235.266 153.387 246.741 149.562 267.007C145.674 286.653 157.533 297.7 157.533 297.7C155.857 300.298 153.645 307.259 153.134 314.899C152.807 319.764 153.801 328.49 156.125 333.891C151.024 344.885 151.146 353.621 151.146 359.129C151.146 371.892 145.577 377.089 138.336 379.36C140.29 386.322 153.275 390.051 160.788 382.612C158.571 404.476 154.473 424.171 148.753 448.546C145.197 465.233 145.796 474.583 148.49 482.5C149.703 486.069 151.604 489.355 153.928 492.319C181.637 527.667 233.629 530.451 269.699 530.451ZM269.655 482.739C259.671 481.116 250.331 476.139 243.515 468.602C225.351 474.618 206.466 459.33 212.205 439.147C213.121 436.505 217.058 437.475 216.668 440.229C216.103 443.783 216.756 447.42 218.281 450.55C222.34 459.827 234.438 462.323 241.853 455.859C244.596 453.441 248.562 454.362 250.424 457.36C266.663 479.4 300.355 475.266 311.654 450.525C313.311 447.069 314.392 443.408 315.021 439.615C315.464 436.924 319.498 437.178 319.61 439.898C320.522 466.525 295.6 486.902 269.65 482.744L269.655 482.739Z'
             fill='#240642'
@@ -7595,7 +7598,7 @@ export function VantaIcon(props: SVGProps<SVGSVGElement>) {
         </g>
       </g>
       <defs>
-        <clipPath id='vanta-icon-clip'>
+        <clipPath id={clipId}>
           <rect width='512' height='512' fill='white' />
         </clipPath>
       </defs>
diff --git a/apps/docs/content/docs/en/integrations/vanta.mdx b/apps/docs/content/docs/en/integrations/vanta.mdx
@@ -332,6 +332,7 @@ Upload an evidence file to a Vanta document. Requires credentials with the vanta
 | `file` | file | No | The evidence file to upload |
 | `fileContent` | string | No | Base64-encoded file content \(alternative to file\) |
 | `fileName` | string | No | Optional file name override |
+| `mimeType` | string | No | MIME type of the file \(e.g., application/pdf\); used when uploading base64 content, since uploaded files already carry their own type |
 | `description` | string | No | Description of the uploaded evidence \(e.g., "Q3 access review evidence"\) |
 | `effectiveAtDate` | string | No | ISO 8601 date indicating when the document is effective from |
 
diff --git a/apps/sim/app/api/tools/vanta/download/route.ts b/apps/sim/app/api/tools/vanta/download/route.ts
@@ -75,18 +75,18 @@ function getFileNameFromContentDisposition(header: string | null): string | null
 export const POST = withRouteHandler(async (request: NextRequest) => {
   const requestId = generateRequestId()
 
-  const authResult = await checkInternalAuth(request, { requireWorkflowId: false })
-  if (!authResult.success) {
-    logger.warn(`[${requestId}] Unauthorized Vanta download attempt`, {
-      error: authResult.error || 'Unauthorized',
-    })
-    return NextResponse.json(
-      { success: false, error: authResult.error || 'Unauthorized' },
-      { status: 401 }
-    )
-  }
-
   try {
+    const authResult = await checkInternalAuth(request, { requireWorkflowId: false })
+    if (!authResult.success) {
+      logger.warn(`[${requestId}] Unauthorized Vanta download attempt`, {
+        error: authResult.error || 'Unauthorized',
+      })
+      return NextResponse.json(
+        { success: false, error: authResult.error || 'Unauthorized' },
+        { status: 401 }
+      )
+    }
+
     const parsed = await parseRequest(vantaDownloadContract, request, {})
     if (!parsed.success) return parsed.response
     const params = parsed.data.body
diff --git a/apps/sim/app/api/tools/vanta/query/route.ts b/apps/sim/app/api/tools/vanta/query/route.ts
@@ -364,18 +364,18 @@ function buildVantaOutput(params: VantaQueryBody, data: unknown): Record<string,
 export const POST = withRouteHandler(async (request: NextRequest) => {
   const requestId = generateRequestId()
 
-  const authResult = await checkInternalAuth(request, { requireWorkflowId: false })
-  if (!authResult.success) {
-    logger.warn(`[${requestId}] Unauthorized Vanta query attempt`, {
-      error: authResult.error || 'Unauthorized',
-    })
-    return NextResponse.json(
-      { success: false, error: authResult.error || 'Unauthorized' },
-      { status: 401 }
-    )
-  }
-
   try {
+    const authResult = await checkInternalAuth(request, { requireWorkflowId: false })
+    if (!authResult.success) {
+      logger.warn(`[${requestId}] Unauthorized Vanta query attempt`, {
+        error: authResult.error || 'Unauthorized',
+      })
+      return NextResponse.json(
+        { success: false, error: authResult.error || 'Unauthorized' },
+        { status: 401 }
+      )
+    }
+
     const parsed = await parseRequest(vantaQueryContract, request, {})
     if (!parsed.success) return parsed.response
     const params = parsed.data.body
diff --git a/apps/sim/app/api/tools/vanta/upload/route.ts b/apps/sim/app/api/tools/vanta/upload/route.ts
@@ -72,11 +72,11 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
 
       fileBuffer = await downloadFileFromStorage(userFile, requestId, logger)
       fileName = params.fileName || userFile.name
-      mimeType = userFile.type || 'application/octet-stream'
+      mimeType = userFile.type || params.mimeType || 'application/octet-stream'
     } else if (params.fileContent) {
       fileBuffer = Buffer.from(params.fileContent, 'base64')
       fileName = params.fileName || 'file'
-      mimeType = 'application/octet-stream'
+      mimeType = params.mimeType || 'application/octet-stream'
     } else {
       return NextResponse.json({ success: false, error: 'File is required' }, { status: 400 })
     }
diff --git a/apps/sim/components/icons.tsx b/apps/sim/components/icons.tsx
@@ -7556,12 +7556,15 @@ export function OnePasswordIcon(props: SVGProps<SVGSVGElement>) {
 }
 
 export function VantaIcon(props: SVGProps<SVGSVGElement>) {
+  const id = useId()
+  const clipId = `vanta_clip_${id}`
+  const maskId = `vanta_mask_${id}`
   return (
     <svg {...props} viewBox='0 0 512 512' fill='none' xmlns='http://www.w3.org/2000/svg'>
-      <g clipPath='url(#vanta-icon-clip)'>
+      <g clipPath={`url(#${clipId})`}>
         <circle cx='256' cy='256' r='256' fill='#AC55FF' />
         <mask
-          id='vanta-icon-mask'
+          id={maskId}
           style={{ maskType: 'alpha' }}
           maskUnits='userSpaceOnUse'
           x='0'
@@ -7571,7 +7574,7 @@ export function VantaIcon(props: SVGProps<SVGSVGElement>) {
         >
           <circle cx='256' cy='256' r='256' fill='#AC55FF' />
         </mask>
-        <g mask='url(#vanta-icon-mask)'>
+        <g mask={`url(#${maskId})`}>
           <path
             d='M269.699 530.451C360.294 530.451 407.136 502.376 421.276 474.223C422.09 472.599 420.53 470.761 418.81 471.332C402.863 476.607 390.96 466.808 389.625 455.498C389.625 455.498 385.167 407.538 369.22 402.858C370.165 400.913 374.01 385.586 362.126 371.424C365.376 361.406 362.691 354.81 360.26 349.823C363.222 346.191 365.498 341.506 366.482 336.943C366.726 335.861 366.721 334.905 367.598 333.887C373.201 329.231 379.384 325.389 383.145 318.574C389.923 306.26 385.382 292.196 377.167 281.817C376.334 280.671 375.681 280.12 375.622 277.176C375.642 272.145 374.731 266.968 372.027 262.717C370.648 260.557 368.84 258.69 366.945 256.959C359.052 249.598 349.609 244.163 340.542 238.293C339.295 237.494 337.843 236.431 337.302 234.978C334.447 224.351 327.065 216.131 317.886 213.894C317.691 206.776 310.187 195.983 298.835 195.983C295.371 195.983 292.506 197.865 290.718 194.623C286.566 186.75 278.293 185.287 273.976 185.088C273.25 185.053 273.046 184.078 273.704 183.766C275.087 183.103 277.182 182.187 280.291 180.988C295.882 173.524 289.431 131.009 283.049 108.575C280.062 100.199 272.49 76.3803 253.942 74.8057C252.665 74.6985 251.359 74.7277 250.126 75.0836C246.555 76.1122 243.909 78.9738 242.048 82.9372C235.914 95.2709 234.379 128.562 232.123 142.797C228.922 163.096 226.023 184.873 215.913 193.799C211.606 182.436 205.374 177.171 201.969 177.37C199.001 178.068 203.016 183.835 201.306 192.341C200.117 197.236 197.408 201.804 192.794 201.804C179.273 201.804 167.098 134.173 163.463 93.5451C163.365 92.4824 163.263 91.4245 163.068 90.3715C161.285 80.5533 156.12 74.757 150.663 74.757C147.896 74.757 137.961 73.7478 126.584 91.639C118.764 105.591 113.795 120.177 113.312 147.341C113.322 174.714 125.532 193.019 130.477 202.023C150.688 235.266 153.387 246.741 149.562 267.007C145.674 286.653 157.533 297.7 157.533 297.7C155.857 300.298 153.645 307.259 153.134 314.899C152.807 319.764 153.801 328.49 156.125 333.891C151.024 344.885 151.146 353.621 151.146 359.129C151.146 371.892 145.577 377.089 138.336 379.36C140.29 386.322 153.275 390.051 160.788 382.612C158.571 404.476 154.473 424.171 148.753 448.546C145.197 465.233 145.796 474.583 148.49 482.5C149.703 486.069 151.604 489.355 153.928 492.319C181.637 527.667 233.629 530.451 269.699 530.451ZM269.655 482.739C259.671 481.116 250.331 476.139 243.515 468.602C225.351 474.618 206.466 459.33 212.205 439.147C213.121 436.505 217.058 437.475 216.668 440.229C216.103 443.783 216.756 447.42 218.281 450.55C222.34 459.827 234.438 462.323 241.853 455.859C244.596 453.441 248.562 454.362 250.424 457.36C266.663 479.4 300.355 475.266 311.654 450.525C313.311 447.069 314.392 443.408 315.021 439.615C315.464 436.924 319.498 437.178 319.61 439.898C320.522 466.525 295.6 486.902 269.65 482.744L269.655 482.739Z'
             fill='#240642'
@@ -7595,7 +7598,7 @@ export function VantaIcon(props: SVGProps<SVGSVGElement>) {
         </g>
       </g>
       <defs>
-        <clipPath id='vanta-icon-clip'>
+        <clipPath id={clipId}>
           <rect width='512' height='512' fill='white' />
         </clipPath>
       </defs>
diff --git a/apps/sim/lib/api/contracts/tools/vanta.ts b/apps/sim/lib/api/contracts/tools/vanta.ts
@@ -678,6 +678,7 @@ export const vantaUploadBodySchema = vantaBaseBodySchema.extend({
   file: FileInputSchema.optional().nullable(),
   fileContent: z.string().nullish(),
   fileName: z.string().nullish(),
+  mimeType: z.string().nullish(),
   description: z.string().nullish(),
   effectiveAtDate: z.string().nullish(),
 })
diff --git a/apps/sim/tools/vanta/types.ts b/apps/sim/tools/vanta/types.ts
@@ -76,6 +76,7 @@ export interface VantaUploadDocumentFileParams extends VantaBaseParams {
   file?: unknown
   fileContent?: string
   fileName?: string
+  mimeType?: string
   description?: string
   effectiveAtDate?: string
 }
diff --git a/apps/sim/tools/vanta/upload_document_file.ts b/apps/sim/tools/vanta/upload_document_file.ts
@@ -59,6 +59,13 @@ export const vantaUploadDocumentFileTool: ToolConfig<
       visibility: 'user-or-llm',
       description: 'Optional file name override',
     },
+    mimeType: {
+      type: 'string',
+      required: false,
+      visibility: 'user-or-llm',
+      description:
+        'MIME type of the file (e.g., application/pdf); used when uploading base64 content, since uploaded files already carry their own type',
+    },
     description: {
       type: 'string',
       required: false,
@@ -85,6 +92,7 @@ export const vantaUploadDocumentFileTool: ToolConfig<
       file: params.file,
       fileContent: params.fileContent,
       fileName: params.fileName,
+      mimeType: params.mimeType,
       description: params.description,
       effectiveAtDate: params.effectiveAtDate,
     }),

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,7 @@ export interface VantaUploadDocumentFileParams extends VantaBaseParams {`
`76`	`76`	`file?: unknown`
`77`	`77`	`fileContent?: string`
`78`	`78`	`fileName?: string`
	`79`	`+ mimeType?: string`
`79`	`80`	`description?: string`
`80`	`81`	`effectiveAtDate?: string`
`81`	`82`	`}`